Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Use modules, safety enums, docs updates #105

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

dogversioning
Copy link
Contributor

@dogversioning dogversioning commented Oct 9, 2023

This PR makes the following changes:

@@ -24,3 +24,23 @@ class JsonFilename(Enum):
TRANSACTIONS = "transactions"
DATA_PACKAGES = "data_packages"
STUDY_PERIODS = "study_periods"


class TransactionKeys(Enum):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we target py3.11, we can just use StrEnum and enum.auto() values to get the lowercase version of the key. And I believe to use the enum directly in place of strings (i.e. no .value needed)

:wistful stare into the distance:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that is supported and i've already got a ticket for it (#104), and that enough is a motivator to do that. Seperate PR, though

@dogversioning dogversioning merged commit 7cd64cd into main Oct 9, 2023
2 checks passed
@dogversioning dogversioning deleted the mg/debt_modules_enums_docs branch February 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants