Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize builders #296

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Reorganize builders #296

merged 3 commits into from
Sep 6, 2024

Conversation

dogversioning
Copy link
Contributor

This preps for cutover of the valueset generator by moving builders to a designated folder, combining some loose builders in the package root with builders in the former statistics folder.

Checklist

  • Consider if documentation in docs/ needs to be updated
    • If you've changed the structure of a table, you may need to run generate-md
    • If you've added/removed core study fields that not in US Core, update our list of those in core-study-details.md
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration in manifest.toml

Copy link

github-actions bot commented Sep 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2017 2004 99% 90% 🟢

New Files

File Coverage Status
cumulus_library/statistics/init.py 100% 🟢
cumulus_library/statistics/counts/init.py 100% 🟢
cumulus_library/statistics/statistics_templates/init.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
cumulus_library/init.py 100% 🟢
cumulus_library/actions/builder.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 35f8841 by action🐍

cumulus_library/statistics/counts/__init__.py Outdated Show resolved Hide resolved
- Moves contents of `statistics` to `builders`
- Moves base_table_builder from root to builders
@dogversioning dogversioning merged commit 7eff201 into main Sep 6, 2024
3 checks passed
@dogversioning dogversioning deleted the mg/valuset-generation branch September 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants