Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action tags to prefer actions using node20 #4

Closed
wants to merge 3 commits into from

Conversation

erikburt
Copy link
Contributor

@erikburt erikburt commented Oct 13, 2023

These 3 action references use node16 but their main branch has been updated to use node20.

golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc -> A:Run golangci-lint -> node16'

actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe -> A:Setup Go environment -> node16'

actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 -> A:Checkout -> node16'

@erikburt erikburt self-assigned this Oct 13, 2023
@erikburt erikburt requested a review from a team as a code owner October 13, 2023 22:38
@erikburt
Copy link
Contributor Author

I need to double check with the renovate bot about how these references are updated.

The problem is, I'm tagging to specific SHAs, but they are not actually included in a tagged release. It seems like we specify a version and the renovate bot will update the SHA tag as releases are made for the version specified.

With my current changes it may actually break that functionality. Going to mark as draft for now.

@erikburt erikburt marked this pull request as draft October 17, 2023 16:54
@erikburt
Copy link
Contributor Author

I need to double check with the renovate bot about how these references are updated.

Renovate bot hasn't been added to this repo since it was made public. I've opened a request to get that added.

@erikburt
Copy link
Contributor Author

Going to split this up into multiple PRs so the main branch changeset is more atomic.

@erikburt erikburt closed this Oct 24, 2023
@erikburt erikburt deleted the re-1955/node-version-bumps branch October 24, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants