Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIB-347] Adding Ingress service endpoints without the ingress base domain in .env format as an output variable #577

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

njegosrailic
Copy link
Contributor

@njegosrailic njegosrailic commented Aug 28, 2024

What

Adding Ingress service endpoints without the ingress base domain in .env format as an output variable.

Why

After deploying a CRIB environment users would like to know the list of available services.

Note: I didn't add protocol here because for web sockets it's not https.

Testing

I have tested it using the simple step:

      - name: Test Ingress Environment Variables
        run: |
          echo "${{ steps.deploy.outputs.ingress-service-names-env }}"
  echo '{"NODE1":"crib-ci-87dbe-node1","NODE2":"crib-ci-87dbe-node2","NODE3":"crib-ci-87dbe-node3","NODE4":"crib-ci-87dbe-node4","NODE5":"crib-ci-87dbe-node5","GETH_1337_HTTP":"crib-ci-87dbe-geth-1337-http","GETH_1337_WS":"crib-ci-87dbe-geth-1337-ws","GETH_2337_HTTP":"crib-ci-87dbe-geth-2337-http","GETH_2337_WS":"crib-ci-87dbe-geth-2337-ws","MOCKSERVER":"crib-ci-87dbe-mockserver","GRAFANA":"crib-ci-87dbe-grafana"}'

echo '{"NODE1":"crib-ci-6e959-node1","NODE2":"crib-ci-6e959-node2","NODE3":"crib-ci-6e959-node3","NODE4":"crib-ci-6e959-node4","NODE5":"crib-ci-6e959-node5","GETH_1337_HTTP":"crib-ci-6e959-geth-1337-http","GETH_1337_WS":"crib-ci-6e959-geth-1337-ws","GETH_2337_HTTP":"crib-ci-6e959-geth-2337-http","GETH_2337_WS":"crib-ci-6e959-geth-2337-ws","MOCKSERVER":"crib-ci-6e959-mockserver","GRAFANA":"crib-ci-6e959-grafana"}' | jq .NODE1
"crib-ci-6e959-node1"

@njegosrailic njegosrailic changed the title Adding Ingress service endpoints without the ingress base domain in .… Adding Ingress service endpoints without the ingress base domain in .env format as an output variable Aug 28, 2024
@njegosrailic njegosrailic force-pushed the nrailic-env-services branch 5 times, most recently from c50be9a to ed38e4d Compare August 28, 2024 17:26
@njegosrailic njegosrailic marked this pull request as ready for review August 28, 2024 17:36
@njegosrailic njegosrailic requested a review from a team as a code owner August 28, 2024 17:36
erikburt
erikburt previously approved these changes Aug 28, 2024
chainchad
chainchad previously approved these changes Aug 29, 2024
scheibinger
scheibinger previously approved these changes Aug 29, 2024
Copy link
Contributor

@scheibinger scheibinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but I'm fine with current implementation as well.

@sebawo sebawo changed the title Adding Ingress service endpoints without the ingress base domain in .env format as an output variable [CRIB-347] Adding Ingress service endpoints without the ingress base domain in .env format as an output variable Aug 29, 2024
Copy link
Contributor

@scheibinger scheibinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants