-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRIB-347] Adding Ingress service endpoints without the ingress base domain in .env format as an output variable #577
Open
njegosrailic
wants to merge
3
commits into
main
Choose a base branch
from
nrailic-env-services
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njegosrailic
changed the title
Adding Ingress service endpoints without the ingress base domain in .…
Adding Ingress service endpoints without the ingress base domain in .env format as an output variable
Aug 28, 2024
njegosrailic
force-pushed
the
nrailic-env-services
branch
5 times, most recently
from
August 28, 2024 17:26
c50be9a
to
ed38e4d
Compare
…main in .env format as an output variable
njegosrailic
force-pushed
the
nrailic-env-services
branch
from
August 28, 2024 17:38
ed38e4d
to
b1233ba
Compare
erikburt
previously approved these changes
Aug 28, 2024
chainchad
previously approved these changes
Aug 29, 2024
scheibinger
reviewed
Aug 29, 2024
scheibinger
previously approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, but I'm fine with current implementation as well.
sebawo
changed the title
Adding Ingress service endpoints without the ingress base domain in .env format as an output variable
[CRIB-347] Adding Ingress service endpoints without the ingress base domain in .env format as an output variable
Aug 29, 2024
njegosrailic
dismissed stale reviews from scheibinger, chainchad, and erikburt
via
August 30, 2024 11:22
84da10f
njegosrailic
force-pushed
the
nrailic-env-services
branch
from
August 30, 2024 11:43
bbad018
to
c558981
Compare
njegosrailic
force-pushed
the
nrailic-env-services
branch
from
August 30, 2024 11:58
c558981
to
9ca9f06
Compare
scheibinger
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding Ingress service endpoints without the ingress base domain in .env format as an output variable.
Why
After deploying a CRIB environment users would like to know the list of available services.
Note: I didn't add protocol here because for web sockets it's not
https
.Testing
I have tested it using the simple step: