feat: Prepend banner and remove lock #701
Open
+68
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchad
reviewed
Nov 8, 2024
| @@ -60,6 +60,18 @@ runs: | |||
| run: | | |||
| go install github.com/kovetskiy/[email protected] | |||
|
|
|||
| - name: Get default branch | |||
| id: get_default_branch | |||
| uses: actions/github-script@v6 | |||
There was a problem hiding this comment.
Suggested change
| uses: actions/github-script@v6 | |
| uses: actions/github-script@v7 |
chainchad
approved these changes
Nov 8, 2024
| --mermaid-provider mermaid-go \ | ||
| --ci | ||
| if [[ -z "${DEFAULT_BRANCH:-}" ]]; then | ||
| echo "DEFAULT_BRANCH is not set. Exiting." |
There was a problem hiding this comment.
Suggested change
| echo "DEFAULT_BRANCH is not set. Exiting." | |
| echo "::error::DEFAULT_BRANCH is not set. Exiting." |
Not crucial but it makes the error obvious in the run logs (highlighted red).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in slack we need to remove edit-lock to unblock the deletion flow, which relies on adding
delete_plslabel