Supported tokens #11
Open
Supported tokens #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrevmatos
requested changes
Jan 9, 2025
andrevmatos
reviewed
Jan 9, 2025
Co-authored-by: André Vitor de Lima Matos <[email protected]>
andrevmatos
reviewed
Jan 15, 2025
andrevmatos
reviewed
Jan 20, 2025
Comment on lines
+43
to
+91
| export const CCIPContractTypeBurnMintTokenPool = 'BurnMintTokenPool' | ||
| export type CCIPContractTypeBurnMintTokenPool = typeof CCIPContractTypeBurnMintTokenPool | ||
| export const CCIPContractTypeBurnMintTokenPoolAndProxy = 'BurnMintTokenPoolAndProxy' | ||
| export type CCIPContractTypeBurnMintTokenPoolAndProxy = | ||
| typeof CCIPContractTypeBurnMintTokenPoolAndProxy | ||
| export const CCIPContractTypeBurnMintTokenPoolWithTax = 'BurnMintTokenPoolWithTax' | ||
|
|
||
| export const CCIPContractTypeBurnWithFromMintTokenPool = 'BurnWithFromMintTokenPool' | ||
| export type CCIPContractTypeBurnWithFromMintTokenPool = | ||
| typeof CCIPContractTypeBurnWithFromMintTokenPool | ||
|
|
||
| export const CCIPContractTypeBurnWithFromMintTokenPoolAndProxy = 'BurnWithFromMintTokenPoolAndProxy' | ||
| export type CCIPContractTypeBurnWithFromMintTokenPoolAndProxy = | ||
| typeof CCIPContractTypeBurnWithFromMintTokenPoolAndProxy | ||
|
|
||
| export type CCIPContractTypeBurnMintTokenPoolWithTax = | ||
| typeof CCIPContractTypeBurnMintTokenPoolWithTax | ||
| export const CCIPContractTypeBurnWithFromMintRebasingTokenPool = 'BurnWithFromMintRebasingTokenPool' | ||
| export type CCIPContractTypeBurnWithFromMintRebasingTokenPool = | ||
| typeof CCIPContractTypeBurnWithFromMintRebasingTokenPool | ||
| export const CCIPContractTypeLockReleaseTokenPool = 'LockReleaseTokenPool' | ||
| export type CCIPContractTypeLockReleaseTokenPool = typeof CCIPContractTypeLockReleaseTokenPool | ||
| export const CCIPContractTypeLockReleaseTokenPoolAndProxy = 'LockReleaseTokenPoolAndProxy' | ||
| export type CCIPContractTypeLockReleaseTokenPoolAndProxy = | ||
| typeof CCIPContractTypeLockReleaseTokenPoolAndProxy | ||
| export const CCIPContractTypeUSDCTokenPool = 'USDCTokenPool' | ||
| export type CCIPContractTypeUSDCTokenPool = typeof CCIPContractTypeUSDCTokenPool | ||
|
|
||
| export const CCIPContractTypeTokenPool = [ | ||
| CCIPContractTypeBurnMintTokenPool, | ||
| CCIPContractTypeBurnMintTokenPoolAndProxy, | ||
| CCIPContractTypeBurnMintTokenPoolWithTax, | ||
| CCIPContractTypeBurnWithFromMintRebasingTokenPool, | ||
| CCIPContractTypeLockReleaseTokenPool, | ||
| CCIPContractTypeLockReleaseTokenPoolAndProxy, | ||
| CCIPContractTypeUSDCTokenPool, | ||
| CCIPContractTypeBurnWithFromMintTokenPoolAndProxy, | ||
| CCIPContractTypeBurnWithFromMintTokenPool, | ||
| ] | ||
| export type CCIPContractTypeTokenPool = | ||
| | CCIPContractTypeBurnMintTokenPool | ||
| | CCIPContractTypeLockReleaseTokenPool | ||
| | CCIPContractTypeLockReleaseTokenPoolAndProxy | ||
| | CCIPContractTypeUSDCTokenPool | ||
| | CCIPContractTypeBurnWithFromMintRebasingTokenPool | ||
| | CCIPContractTypeBurnMintTokenPoolAndProxy | ||
| | CCIPContractTypeBurnMintTokenPoolWithTax | ||
| | CCIPContractTypeBurnWithFromMintTokenPoolAndProxy | ||
| | CCIPContractTypeBurnWithFromMintTokenPool |
There was a problem hiding this comment.
Do we really need these contract types here?
When I created them, it was with the assumption that token pools were not strictly part of the ccip core contracts. They can even be implemented by 3Ps, and not comply with our interfaces at all.
I'd rather leave them to some self-contained command, and not tie them directly into lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CCIP Supported Tokens Discovery Command
This PR adds a new command to discover and display tokens that are supported for CCIP cross-chain transfers between two chains.
Features
supported-tokenscommand to check CCIP-supported tokensImplementation Details
src/commands/supported-tokens.tsUsage
Check supported tokens between chains
npx tsx src/index.ts supported-tokens <source> <router> <dest> [--format <format>]Example
npx tsx src/index.ts supported-tokens ethereum-mainnet 0x80226fc0Ee2b096224EeAc085Bb9a8cba1146f7D avalanche-mainnet