Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream 27 sep 2024 #1474

Open
wants to merge 215 commits into
base: ccip-develop
Choose a base branch
from
Open

Merge upstream 27 sep 2024 #1474

wants to merge 215 commits into from

Conversation

valerii-kabisov-cll
Copy link
Contributor

Motivation

Solution

momentmaker and others added 30 commits July 29, 2024 20:05
@momentmaker
chore: update dependabot config yaml (#13949)
d3198a6
@HenryNguyen5
Refactor jira update script to use typescript (#13860)
bf30e1d 
* Refactor jira update script to use typescript

* Make use of TS 5.5 inferred type predicate

* Add tests

* Add dryrun capability

* Add more logging

* Address comments
@chainchad
Fix syntax error in workflow (#13952)
7147653
@dhaidashenko @amit-momin
No new finalized Heads Implementation (#13907)
1eaf5e0 
* No new finalized Heads Implementation

* fixed tests

* update defaults for NoNewFinalizedHeadsThreshold

* Update common/client/node_lifecycle.go

Co-authored-by: amit-momin <[email protected]>

* Update common/client/node_lifecycle_test.go

Co-authored-by: amit-momin <[email protected]>

* Update common/client/node_lifecycle_test.go

Co-authored-by: amit-momin <[email protected]>

* rename HeadIsNotIncreasing to NoNewHead

* move and add docs for syncIssue consts

* rename syncIssue to syncStatus

---------

Co-authored-by: amit-momin <[email protected]>
@cedric-cordenier
[fix] Race in workflow engine (#13879)
c3dc764 
* [fix] Fix race in workflow engine

* Remove unused mutex
@Tofel
fix releases path in notification (#13959)
3fc7285
@kalverra
[TT-1422] Properly Handles Group Slack Handle (#13950)
9e8ebc2
@RensR
Port ccip onchain to chainlink (#13941)
9e74eee 
* init port

* install dependencies and create snapshots

* add to foundry ci

* fix readme

* fix ci & add changeset

* fix fuzz exclusion

* update license & solhint

* add ccip solidity CI

* fix coverage pruning

* Update LICENSE

* Update LICENSE

* fix job name
@anirudhwarrier
update tests Dockerfile to copy only required files (#13961)
6b3f6e2
@Fletch153 @samsondav
@app-token-issuer-infra-releng @dav009 @ad0ll @msuchacz-cll
Initial Impl of SBRV (#13813)
c4ffbfb 
* Initial Impl of SBRV

* Generate wrappers/ABI

* Removed ZeroAddress check for feemanager & AC

* Update gethwrappers

* Rename RewardManager=>DestinationRewardManager

* Remove circular dependency between proxy and verifier

* Fixes to init logic

* Update gethwrappers

* llo-feeds: v0.4.0 reward manager tests

* Add check to remove assumption that feeManager cannot be nil

* Generate

* Fixed poolIdMismatch not being thrown

* Fix logic error when looking up the activeDonConfig

* Update gethwrappers

* Update interface sanity checks when setting verifier

* Add remaining interface functionality

* Update gethwrappers

* llo-feeds: verifier SetConfig tests

* llo-feeds: adding verifier contract get methods for easier testing

* adding rewards wire up for testing

* incomeplte fix for test_setConfigWithAddressesAndWeightsAreSetCorrectly

* llo-feeds: adjusting setConfig tests due to changes

* llo-feeds: fee manager v0.4.0 tests: making v0.3.0 tests pass

* llo-feeds: fee manager v0.4.0 tests: fee manager - adding test for PoolIdMismatch

* llo-feeds: fee manager v0.4.0 tests: nits

* llo-feeds: feeManager bulk reverts when PoolId is 0

* llo-feeds: feeManager tests revertOnSettingAnAddressZeroVerifier onlyCallableByOwnerReverts

* llo-feeds: feeManager test poolIdsCannotBeZeroAddress

* llo-feeds: rewardManager test_rewardsAreCorrectlySentToEachAssociatedPoolWhenVerifyingInBulk

* llo-feeds: verifier proxy tests

* llo-feeds: fixing DestinationProxy error handling

* llo-feeds: fixing DestinationProxy test remove verifiercontract zero check

* llo-feeds: remove interface checks for verifierProxy

* llo-feeds: clean up setConfig tests from checking internal state

* fix issue when processing rewards

* Apply suggestions from code review

* Update contracts/src/v0.8/llo-feeds/v0.4.0/DestinationFeeManager.sol

* Update contracts/src/v0.8/llo-feeds/v0.4.0/DestinationVerifierProxy.sol

* llo-feeds: verifier proxy remove test test_setVerifierZeroVerifier

* llo-feeds: tests for verify and verifyBulk

* clean up

* temporal fix for compile error

* llo: v0.4.0 removing V1 report tests

* better comments

* llo-feeds: verify test test_rollingOutConfiguration

* llo-feeds: verify test test_verifyFailsWhenReportIsOlderThanConfig

* llo-feeds: verify test test_verifyFailsWhenReportIsOlderThanConfig

* llo-feeds: tests for billing / billing bulk

* fixing tests

* fixing tests names

* llo-feeds: fix proxy contract should send value in call to verify

* llo-feeds: fix billing tests

* squash me

* llo-feeds: billing bulk verify tests

* llo-feeds: clean up

* llo-feeds: VerifierSetAccessControllerTest

* llo-feeds: clean up

* llo-feeds: extra proxy tests

* Update contracts/src/v0.8/llo-feeds/v0.4.0/DestinationFeeManager.sol

* Fix issue with oldest config verifying incorrectly

* Fix issue with oldest config verifying incorrectly

* llo-feeds: fix underflow and test_verifyFailsWhenReportIsOlderThanConfig

* Update gethwrappers

* Update gethwrappers

* llo-feeds: DestinationVerifier setFeeManager tests

* llo-feeds: Tests for Rewards and configs

* llo-feeds: Tests for DestinationVerifier constructor

* llo-feeds: reverse looping efficiently

* Update contracts/src/v0.8/llo-feeds/v0.4.0/DestinationVerifier.sol

* Update gethwrappers

* llo-feeds: fmt contract tests

* llo-feeds: npx prettify contract tests

* llo-feeds: npx prettify v0.4.0 contracts

* se --Add ability to amend config array

* Update gethwrappers

* Fix issue with future timestamps

* Update gethwrappers

* Small fix

* Fix broken tests

* Update gethwrappers

* llo-feeds: Tests setConfigWithActivationTime

* llo-feeds: Tests setConfigWithActivationTime

* llo-feeds: Tests VerifierRemoveLatestConfigTest

* llo-feeds: fixing linter errors (unused imports)

* llo-feeds: tests better filenaming

* Improve upgradability of contracts

* Update gethwrappers

* Small fix when setting rewardManager

* Update gethwrappers

* Fix var name to honour same interface

* Update gethwrappers

* Improve getter consistency

* Update gethwrappers

* Fix comments & conventions

* Update DON Config to camal case

* Update gethwrappers

* solhint + gas snapshot

* prettier

* Solhint fixes

* Update gethwrappers

* gas snapshot

* Fixed gas issue

* Gas snapshot

* llo-feeds: testing multiple fee managers and verifiers

* llo: fixing tests

* Update contracts/src/v0.8/llo-feeds/v0.4.0/test/verifier/DestinationVerifierTestRewardsMultiVefifierFeeManager.t.sol

Co-authored-by: msuchacz-cll <[email protected]>

* llo: v0.4.0 interfaces test

* Fixed gas snaposhot

* prettier

* Generate

---------

Co-authored-by: Sam Davies <[email protected]>
Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Co-authored-by: David Przybilla <[email protected]>
Co-authored-by: ad0ll <[email protected]>
Co-authored-by: msuchacz-cll <[email protected]>
@cedric-cordenier
[KS-393] Handle nils values (#13945)
d591645 
* KS-393: Incorporate values lib improvements

* Incorporate bytes Copy fix
@RensR @asoliman92
add ccip and liq man gethwrappers (#13967)
afe2b25 
* add gethwrappers

* liqMan wrappers

* port mockery mocks

---------

Co-authored-by: Abdelrahman Soliman (Boda) <[email protected]>
@kalverra
[TT-1422] Fix Slack Tag (#13971)
24c4826
@kalverra
Build Image for Tags (#13965)
3de00b7
@dhaidashenko
BCI-3842 custom timeouts for Hedera (#13876)
15dc74c 
* allow to configure RPCTimeouts

* Custom (30s) timeout for Hedera RPC requests with large payloads (SendTransaction, CallContext, etc.)

* fix linter
@kalverra
Updates CTF and removes some replaces (#13980)
94aa60d
@bolekk
[Keystone] Fix init order for Peer Wrapper and Dispatcher (#13976)
610a516
@amit-momin
Add nonce validation after broadcast for Hedera (#13957)
20dbba8 
* Added post-broadcast nonce validation for Hedera

* Added changeset

* Updated chaintype docs for Hedera

* Fixed lint errors

* Added condition to handle on-chain seq less than tx seq and updated comment
@Tofel
[TT-1394] add Reth to compatibility pipeline (#13804)
f974754 
* add support to compat pipeline for reth

* npe protection, step condition streamlining

* update compat pipeline

* do not fetch latest images if base64 input is passed

* use tagged CTF

* check if Reth docker images are up to date

* update compat pipeline with latest update images version

* update pipeline reference
@jmank88
core: add -failing filter to health command (#13989)
1d12fbf
@chainchad
Bump version and update CHANGELOG fore core v2.15.0 (#13948)
3b4c2b5 
* Bump version and update CHANGELOG fore core v2.15.0

Signed-off-by: chainchad <[email protected]>

* Fix changelog version

* Back out local only change

* Remove dupe CL entry

* Create init changeset for next release

* Use changeset github changelog generator

(cherry picked from commit 69cccdf)

---------

Signed-off-by: chainchad <[email protected]>
@chainchad
Remove old CRIB remnants (cleanup) (#13912)
5eb95f1
@jmank88
align prom (#13995)
1b4cb83
@cedric-cordenier
[fix] Check if DefaultConfig is nil before merging (#13988)
0e8f2de
@HenryNguyen5
Nuke unused files (#14010)
4a78286
@KodeyThomas
Add L3X Config (#13987)
c1bd103 
* Add L3X Config

* Changeset

* comments

* comments
@DeividasK @app-token-issuer-infra-releng
Disallow zero address signers + pin Solidity version (#13993)
f5e0bd6 
* Disallow zero address signer

* pragma ^0.8.19 => 0.8.24

* Changesets

* Update gethwrappers

---------

Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
@amit-momin
Update AutoPurge config interface and add header for Scroll API (#13999)
2a032e8 
* Updated AutoPurge heuristic configs to be optional

* Added content-type header for Scroll stuck tx API call

* Fixed linting

* Added changeset
@ettec
fix keystone e2e test dispatcher to correctly replicate duplicate reg…
82accff 
…istration behaviour (#14018)
@jmank88
common/headtracker: improve health error (#13966)
af7dab6
@valerii-kabisov-cll valerii-kabisov-cll requested a review from a team as a code owner October 2, 2024 15:14
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)
6 New Major Issues (required ≤ 5)
2 New Blocker Issues (required ≤ 0)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR left review comments

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner

@jmank88 jmank88 Awaiting requested review from jmank88 jmank88 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.