Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCIP-3973] adding info about unknown forge chains #1511

Open
wants to merge 1 commit into
base: ccip-develop
Choose a base branch
from
Open

[CCIP-3973] adding info about unknown forge chains #1511

wants to merge 1 commit into from

Conversation

valerii-kabisov-cll
Copy link
Contributor

Motivation

Some of the chains for the forge tool are unknown.

Solution

Add a matching between chain - chainID - blockExplorer. To allow manual verification of unknown (not in forge db) chains

https://smartcontract-it.atlassian.net/browse/CCIP-3973

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit d8fe9fb during Solidity Foundry #8671

Summary coverage rate:
  lines......: 97.9% (2283 of 2333 lines)
  functions..: 95.1% (429 of 451 functions)
  branches...: 93.6% (539 of 576 branches)

Files changed coverage rate: n/a

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@matYang matYang requested a review from RensR October 28, 2024 17:49
@matYang
Copy link
Collaborator

matYang commented Oct 30, 2024

with the new PR that uses chainlink-deployments as SoT for etherscan endpoints, this PR can be closed right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matYang matYang matYang approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

@RensR RensR Awaiting requested review from RensR

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valerii-kabisov-cll @matYang