add test for unique chainID and family

selectors.go

@@ -82,15 +82,6 @@ func ChainSelectorToChainDetails() map[uint64]ChainDetails {
 	return copyMap
 }
 
-func TestChainSelectorToChainDetails() map[uint64]ChainDetails {
-	copyMap := make(map[uint64]ChainDetails, len(selectorsMap))
-	for k, v := range testSelectorsMap {
-		copyMap[k] = v
-	}
-
-	return copyMap
-}
-
 func GetSelectorFamily(selector uint64) (string, error) {
 	// previously selector_families.yml includes both real and test chains, therefore we check both maps
 	details, exist := chainIdToChainSelector[selector]

selectors_test.go

@@ -13,13 +13,24 @@ import (
 func TestNoSameChainSelectorsAreGenerated(t *testing.T) {
 	chainSelectors := map[uint64]struct{}{}
 
-	for selector := range selectorsMap {
+	for selector := range chainIdToChainSelector {
 		_, exist := chainSelectors[selector]
 		assert.False(t, exist, "Chain Selectors should be unique. Selector %d is duplicated for chain %d", selector)
 		chainSelectors[selector] = struct{}{}
 	}
 }
 
+func TestNoSameChainIDAndFamilyAreGenerated(t *testing.T) {
+	chainIDAndFamily := map[string]struct{}{}
+
+	for _, details := range chainIdToChainSelector {
+		key := fmt.Sprintf("%s:%s", details.ChainID, details.Family)
+		_, exist := chainIDAndFamily[key]
+		assert.False(t, exist, "ChainID within single family should be unique. chainID %s is duplicated for family", details.ChainID, details.Family)
+		chainIDAndFamily[key] = struct{}{}
+	}
+}
+
 func TestNoOverlapBetweenRealAndTestChains(t *testing.T) {
 	for k, _ := range selectorsMap {
 		_, exist := testSelectorsMap[k]
@@ -166,7 +177,7 @@ func Test_ChainNames(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			chainId, err1 := ChainIdFromNameAndFamily(test.chainName, "")
+			chainId, err1 := ChainIdFromName(test.chainName)
 			selector, err2 := SelectorFromChainIdAndFamily(chainId, "")
 			if test.expectErr {
 				require.Error(t, err1)