Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-EVM support with backwards compatibility #69

Closed
wants to merge 3 commits into from

Conversation

connorwstein
Copy link
Collaborator

@connorwstein connorwstein commented Nov 6, 2024

Here we just commit to family specific selector ymls for backwards compatibility. Meaning

  • EVM: selectors.yml, test_selectors.yml all Go code using those are renamed to have evm in the filename and non-public methods similarly prefixed with evm.
  • Solana: selectors_solana.yml follows the same pattern where the yaml key is the family specific ID and the selector + name is a value.
  • selectors.go is reserved for family agnostic Go code. We can extend it to use all the family specific yamls for various family agnostic functions (like looking up the name for a selector)

@connorwstein
Copy link
Collaborator Author

closing in favour of #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant