Removing redundant types

smartcontractkit · Feb 12, 2025 · a5a93b8 · a5a93b8
1 parent 320c72a
commit a5a93b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/commit/metrics/reporter.go b/commit/metrics/reporter.go
@@ -5,7 +5,6 @@ import (
 
 	"github.com/smartcontractkit/chainlink-ccip/commit/committypes"
 	"github.com/smartcontractkit/chainlink-ccip/commit/merkleroot"
-	"github.com/smartcontractkit/chainlink-ccip/commit/tokenprice"
 	"github.com/smartcontractkit/chainlink-ccip/internal/plugintypes"
 )
 
@@ -43,18 +42,10 @@ func (n *Noop) TrackObservation(committypes.Observation) {}
 
 func (n *Noop) TrackOutcome(committypes.Outcome) {}
 
-func (n *Noop) TrackMerkleObservation(merkleroot.Observation, string) {}
-
-func (n *Noop) TrackMerkleOutcome(merkleroot.Outcome, string) {}
-
 func (n *Noop) TrackRmnReport(float64, bool) {}
 
 func (n *Noop) TrackRmnRequest(string, float64, uint64, string) {}
 
-func (n *Noop) TrackTokenPricesObservation(tokenprice.Observation) {}
-
-func (n *Noop) TrackTokenPricesOutcome(tokenprice.Outcome) {}
-
 func (n *Noop) TrackProcessorLatency(string, string, time.Duration, error) {}
 
 func (n *Noop) TrackProcessorObservation(string, plugintypes.Trackable) {}

diff --git a/internal/plugintypes/common.go b/internal/plugintypes/common.go
@@ -37,6 +37,10 @@ func NewUSD18(value int64) USD18 {
 	return big.NewInt(value)
 }
 
+// Trackable is an interface for types that can be tracked using Prometheus metrics.
+// That way we are moving responsibility of presenting proper stats and metrics to
+// the underlying types. It's meant to be implemented by Observation and Outcome in
+// the Commit Plugin's processors.
 type Trackable interface {
 	Stats() map[string]int
 }