Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clearer that offRamp configs are only read from DestChain #543

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Make it clearer that offRamp configs are only read from DestChain #543

wants to merge 6 commits into from
+151 −32

Conversation

asoliman92
Copy link
Contributor

@asoliman92 asoliman92 commented Feb 3, 2025 •
edited
Loading

  • Add validation for FChain in DiscoveryProcessor
  • DestChain is essential for all contract discovery observations
  • OnRamps are essential for feequoter and router discoveries
  • Add tests
  • Make it clearer that offRamp configs are only read from DestChain

@asoliman92 asoliman92 force-pushed the CCIP-4928-discovery-processor-validation branch from f847009 to a887689 Compare February 3, 2025 15:07
@asoliman92 asoliman92 force-pushed the CCIP-4928-discovery-processor-validation branch from a887689 to 8c2aacb Compare February 3, 2025 15:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Metric CCIP-4928-discovery-processor-validation main
Coverage 75.6% 75.5%

@asoliman92 asoliman92 marked this pull request as ready for review February 3, 2025 15:49
@asoliman92 asoliman92 requested a review from a team as a code owner February 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asoliman92