make tests pass

pkg/codec/by_item_type_modifier.go

@@ -2,7 +2,6 @@ package codec
 
 import (
 	"fmt"
-	"log"
 	"reflect"
 
 	"github.com/smartcontractkit/chainlink-common/pkg/types"
@@ -51,7 +50,6 @@ func (b *byItemTypeModifier) RetypeToOffChain(onChainType reflect.Type, itemType
 
 	mod, ok := b.modByitemType[head]
 	if !ok {
-		log.Println(mod)
 		return nil, fmt.Errorf("%w: cannot find modifier for %s", types.ErrInvalidType, itemType)
 	}
 
@@ -78,11 +76,12 @@ func (b *byItemTypeModifier) transform(
 		head, tail = ItemTyper(itemType).Next()
 	}
 
-	if mod, ok := b.modByitemType[head]; ok {
-		return transform(mod, val, tail)
+	mod, ok := b.modByitemType[head]
+	if !ok {
+		return nil, fmt.Errorf("%w: cannot find modifier for %s", types.ErrInvalidType, itemType)
 	}
 
-	return val, nil
+	return transform(mod, val, tail)
 }
 
 var _ Modifier = &byItemTypeModifier{}

pkg/codec/renamer_test.go

@@ -28,9 +28,9 @@ func TestRenamer(t *testing.T) {
 		D string
 	}
 
-	renamer := codec.NewRenamer(map[string]string{"A": "X", "C": "Z"})
-	invalidRenamer := codec.NewRenamer(map[string]string{"W": "X", "C": "Z"})
-	nestedRenamer := codec.NewRenamer(map[string]string{"A": "X", "B.A": "X", "B.C": "Z", "C.A": "X", "C.C": "Z", "B": "Y"})
+	renamer := codec.NewPathTraverseRenamer(map[string]string{"A": "X", "C": "Z"}, true)
+	invalidRenamer := codec.NewPathTraverseRenamer(map[string]string{"W": "X", "C": "Z"}, true)
+	nestedRenamer := codec.NewPathTraverseRenamer(map[string]string{"A": "X", "B.A": "X", "B.C": "Z", "C.A": "X", "C.C": "Z", "B": "Y"}, true)
 	t.Run("RetypeToOffChain renames fields keeping structure", func(t *testing.T) {
 		offChainType, err := renamer.RetypeToOffChain(reflect.TypeOf(testStruct{}), "")
 		require.NoError(t, err)