Various updates to observabilty library #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
Atrax1
reviewed
Jan 13, 2025
Comment on lines
+496
to
+498
| if options.EnableLogDetails == nil { | ||
| options.EnableLogDetails = Pointer[bool](true) | ||
| } |
There was a problem hiding this comment.
So we enable by default log details
There was a problem hiding this comment.
Yes, most of the defaults that I have added are the same defaults if you were to use the UI.
Atrax1
approved these changes
Jan 13, 2025
Atrax1
requested review from
a team,
krehermann and
patrickhuie19
and removed request for
a team
krehermann
approved these changes
Jan 13, 2025
leeyikjiun
force-pushed
the
obs-lib-updates
branch
from
840c900 to
dc76a11
Compare
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
- Add text panel - Make Title and Decimals in panel nullable - Add LineWidth and DrawStyle to time series panel - Add more configs to log panel - Add Hide to custom variable
leeyikjiun
force-pushed
the
obs-lib-updates
branch
from
dc76a11 to
9615dc6
Compare
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
Making title and decimals nullable is a BREAKING CHANGE.
nilwhich will becomeautoin Grafana is better than manually figuring out the real dp.