Gauntlet inspection command #39
Conversation
RodrigoAD
force-pushed
the
gauntlet-inspection-command
branch
from
342b558
to
84c69da
Compare
packages-ts/gauntlet-terra-contracts/src/commands/contracts/ocr2/inspection/inspect.ts
Outdated
Show resolved
Hide resolved
| import { InspectInstruction, InspectionInput, instructionToInspectCommand } from '../../../abstract/inspectionWrapper' | ||
| import { getOffchainConfigInput, OffchainConfig } from '../setConfig' | ||
|
|
||
| type Expected = { |
There was a problem hiding this comment.
I'd suggest another name here:
| type Expected = { | |
| type OnChainData = { |
There was a problem hiding this comment.
Expected is also the user input, what the OnChainData will be checked against.
| return { | ||
| description, | ||
| decimals, | ||
| minAnswer: 'INFO NOT AVAILABLE IN CONTRACT', |
There was a problem hiding this comment.
Why/how are these handled then?
There was a problem hiding this comment.
AFAIK they are not exposed in the contract. @archseer is there any way to get these?
There was a problem hiding this comment.
Not sure if Solidity exposes these either, but I can add a query for them if needed?
| } | ||
| } | ||
|
|
||
| const makeOnchainData = (instructionsData: any[]): Expected => { |
There was a problem hiding this comment.
It would be more readable (also safer when typed) to name instruction outputs in an object instead of appending them to the array. Please consider for future improvements.
There was a problem hiding this comment.
Right, I can fix it in this PR
There was a problem hiding this comment.
I'll open an issue for this, currently no time to do it
packages-ts/gauntlet-terra-contracts/src/commands/abstract/inspectionWrapper.ts
Outdated
Show resolved
Hide resolved
RodrigoAD
force-pushed
the
gauntlet-inspection-command
branch
from
3026d3a
to
ca931ae
Compare
RodrigoAD
force-pushed
the
gauntlet-inspection-command
branch
from
ca931ae
to
cfee50b
Compare
RodrigoAD
force-pushed
the
gauntlet-inspection-command
branch
from
cfee50b
to
f356a75
Compare
No description provided.