Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cairo 2.8.2 #533

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Cairo 2.8.2 #533

wants to merge 4 commits into from

Conversation

augustbleeds
Copy link
Collaborator

@augustbleeds augustbleeds commented Sep 27, 2024 •
edited
Loading

Note: this will NOT be merged to develop until the audit is completed in order to avoid the situation where Ops deploys updated contracts.

Bumping scarb/cairo to version 2.8.2. Because this changes the compile contracts (and the dependencies), this will stay as a PR and will not be merged. After the audit is completed, then it'll be merged to develop

  • bump cairo/starknet version
  • open zeppelin bump -- make sure OZ is updated, but also bc there is a breaking erc-20 change for event indexing
  • update build process (no longer use cairo directly, but via scarb)
  • update foundry
  • add recently added contracts (MCM + Timelock)

augustbleeds
augustbleeds commented Sep 30, 2024
View reviewed changes
.github/actions/install-cairo/action.yml Outdated
tar -xvzf scarb-${{ inputs.scarb_version }}-x86_64-unknown-linux-musl.tar.gz
mv -vf scarb-${{ inputs.scarb_version }}-x86_64-unknown-linux-musl scarb-build
wget https://github.com/software-mansion/scarb/releases/download/${{ inputs.scarb_version }}/scarb-${{ inputs.scarb_version }}-x86_64-unknown-linux-gnu.tar.gz
tar -xvzf scarb-${{ inputs.scarb_version }}-x86_64-unknown-linux-gnu.tar.gz
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the musl version does not work anymore. gnu version does though

@augustbleeds augustbleeds changed the title Augustus.compile bump cairo Cairo 2.8.2 Sep 30, 2024
archseer
archseer reviewed Oct 1, 2024
View reviewed changes
contracts/Scarb.toml Outdated
Comment on lines 18 to 22
alexandria_bytes = { git = "https://github.com/keep-starknet-strange/alexandria.git", rev = "e1b080577aaa6889116fc8be5dde72b2fd21e397" }
alexandria_encoding = { git = "https://github.com/keep-starknet-strange/alexandria.git", rev = "e1b080577aaa6889116fc8be5dde72b2fd21e397" }

[dev-dependencies]
alexandria_math = { git = "https://github.com/keep-starknet-strange/alexandria.git", rev = "e1b080577aaa6889116fc8be5dde72b2fd21e397" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new dependencies?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's for MCMS. When I created this PR, MCMS wasn't fully merged to develop yet. Need to add them to this branch

@augustbleeds augustbleeds marked this pull request as draft October 8, 2024 20:11
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

calvwang9
calvwang9 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@calvwang9 calvwang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, although i dont have much context around cairo updates

contracts/src/access_control/rbac_timelock.cairo
Comment on lines -44 to -45
fn get_blocked_function_selector_count(self: @TContractState) -> u256;
fn get_blocked_function_selector_at(self: @TContractState, index: u256) -> felt252;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this functionally change the interface, i.e. tooling needs updating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer left review comments

@calvwang9 calvwang9 calvwang9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@augustbleeds @archseer @calvwang9