Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test commit #15129

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AKhozya
Copy link

@AKhozya AKhozya commented Nov 6, 2024

Requires

Supports

@AKhozya AKhozya requested review from a team as code owners November 6, 2024 01:48
Copy link
Contributor

github-actions bot commented Nov 6, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@AKhozya AKhozya requested a review from 007vasy November 6, 2024 01:52
@AKhozya AKhozya marked this pull request as draft November 6, 2024 01:54
@AKhozya AKhozya removed the request for review from chudilka1 November 6, 2024 01:54
Copy link
Contributor

github-actions bot commented Nov 6, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Root Project / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Root Project / Run Tests , Find New Flaky Tests In Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Comment formatting issues: Golang Lint

Source of Error:
Golang Lint	2024-11-06T01:55:05.2910579Z ##[error]internal/testdb/testdb.go:25:59: commentFormatting: put a space between `//` and comment text (gocritic)
Golang Lint	2024-11-06T01:55:05.2912600Z 		return "", errors.New("path missing from database URL") //test
Golang Lint	2024-11-06T01:55:05.2913959Z 		 ^
Golang Lint	2024-11-06T01:55:05.2916192Z ##[error]core/chains/chain_kv.go:14:22: commentFormatting: put a space between `//` and comment text (gocritic)
Golang Lint	2024-11-06T01:55:05.2917389Z 	chains map[string]T //test
Golang Lint	2024-11-06T01:55:05.2918028Z 	 ^
Golang Lint	2024-11-06T01:55:05.2920229Z ##[error]plugins/cmd/chainlink-medianpoc/main.go:18:17: commentFormatting: put a space between `//` and comment text (gocritic)
Golang Lint	2024-11-06T01:55:05.2921671Z 	defer s.Stop() //test
Golang Lint	2024-11-06T01:55:05.2922224Z 	 ^

Why: The linter gocritic detected comments that do not have a space between the // and the comment text, which is a common style guideline in Go to improve readability.

Suggested fix: Add a space between // and the comment text in the affected lines. For example, change //test to // test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant