Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rmn curse changeset #15868
New rmn curse changeset #15868
Changes from all commits
d76dcea
305e712
b217f52
79a3324
fe5bf11
df42f76
3863f82
abeba1a
f3cf0b3
0a953e5
ebb18e0
acd4df8
b9b5a88
adacbde
c863d70
ac43c5a
37abca0
ecadeb1
d2e8683
f80a6e5
e5436d6
2597661
23b24e2
0f808af
95e4256
235ecaf
19e3410
0cd231c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a simpler approach to me:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be missing some parts, ie if the GlobalSubject is part of the subject to curse on a chain we would want to only keep this one when keepOnlyGlobal is active. I updated the original to be clearer let me know if it looks good to you