Solana changeset support for e2e testing #15892
Conversation
This reverts commit aaab52e.
…k into solana-link-deploy
…k into solana-link-deploy
…k into solana-updates
…t/chainlink into solana-home-chain-update
This reverts commit 2f315cd.
tt-cll
changed the title
tt-cll
changed the title
tt-cll
changed the title
|
| chainState, ok := state.Chains[chainSel] | ||
| if !ok { | ||
| return fmt.Errorf("chain %d not found in onchain state", chainSel) | ||
| } |
There was a problem hiding this comment.
This check probably needs removing right? Otherwise it'll only permit EVM chains
There was a problem hiding this comment.
I think long-term we need to rename state.Chains to state.EVMChains so it's a bit more obvious in code, but that's going to be a large diff
There was a problem hiding this comment.
Sorry, forgot to mention that UpdateOnRampsDestsChangeset is out of scope for this PR. This refactor is a bit bigger so we wanted to split it out. This is just starting to partition the checks into EVM vs non-EVM. And definitely agree about state.Chains vs state.EVMChains
| proposers[remote] = state.Chains[remote].ProposerMcm | ||
| } | ||
| case chain_selectors.FamilySolana: | ||
| // TODO: check if ocr3 has already been set |
There was a problem hiding this comment.
The EVM code calls a line isOCR3ConfigSetOnOffRamp. We need a similar check on Solana but it shouldn't interfere with the initial configuration we need for unit tests or E2E. We're marking this as a TODO because we will need it for full functionality but don't need it for happy path E2E.
| // TODO: what if chain family is solana ? | ||
| // bytes4(keccak256("CCIP ChainFamilySelector EVM")) | ||
| ChainFamilySelector: [4]uint8{40, 18, 213, 44}, |
There was a problem hiding this comment.
Yes anything with a TODO we will need to follow up on before this is prod ready.
| IsEnabled: update.EnabledAsSource, | ||
| } | ||
| // TODO: this should be GetDestChainStatePDA | ||
| destChainStatePDA := cs.GetEvmDestChainStatePDA(ccipRouterID, destination) |
There was a problem hiding this comment.
This needs a selector probably?
Requires
Supports