Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/chains/evm: remove heavyweight db package dependency #16157

Merged
merged 1 commit into from
Jan 31, 2025
Merged

core/chains/evm: remove heavyweight db package dependency #16157

merged 1 commit into from
Jan 31, 2025

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 30, 2025

@jmank88 jmank88 mentioned this pull request Jan 30, 2025
Merged
@jmank88 jmank88 requested a review from pavel-raykov January 30, 2025 20:16
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@jmank88 jmank88 force-pushed the evm-test-db branch 2 times, most recently from 87a602c to c83370d Compare January 30, 2025 20:54
pavel-raykov
pavel-raykov previously approved these changes Jan 30, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 marked this pull request as ready for review January 30, 2025 21:49
@jmank88 jmank88 requested review from a team and DylanTinianov as code owners January 30, 2025 21:49
pavel-raykov
pavel-raykov previously approved these changes Jan 31, 2025
View reviewed changes
@jmank88 jmank88 requested a review from pavel-raykov January 31, 2025 14:30
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 enabled auto-merge January 31, 2025 14:51
@jmank88 jmank88 added this pull request to the merge queue Jan 31, 2025
krehermann
krehermann reviewed Jan 31, 2025
View reviewed changes
evm/testutils/sql.go
// pristineDBName is a clean copy of test DB with migrations.
const pristineDBName = "chainlink_test_pristine" //TODO update when splitting schemas

// NewIndependentSqlxDB return a new independent test database, which does not use txdb and therefore supports txs etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the logical distinction between this and HeavyweightDB?

when would i use one vs the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The evm/ subtree will move to the new module. This can be made internal then.

Merged via the queue into develop with commit 380d8fa Jan 31, 2025
186 of 192 checks passed
@jmank88 jmank88 deleted the evm-test-db branch January 31, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann left review comments

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@samsondav samsondav samsondav approved these changes

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

@kalverra kalverra Awaiting requested review from kalverra

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

@chudilka1 chudilka1 Awaiting requested review from chudilka1

@ilija42 ilija42 Awaiting requested review from ilija42

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmank88 @samsondav @krehermann @DylanTinianov @pavel-raykov