-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chain data #1426
Merged
yacine-benichou
merged 14 commits into
smartcontractkit:main
from
simkasss:move-chain-data
Aug 8, 2023
Merged
Move chain data #1426
yacine-benichou
merged 14 commits into
smartcontractkit:main
from
simkasss:move-chain-data
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simkasss
requested review from
dwightjl,
ritika-b,
aelmanaa,
thedriftofwords and
yacine-benichou
as code owners
August 1, 2023 10:10
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
simkasss
force-pushed
the
move-chain-data
branch
from
August 3, 2023 09:36
790f940
to
41d3393
Compare
yacine-benichou
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great job Thanks for this ! I left a nitpick as a comment but otherwise everything looks good.
* Add feed notice capability --------- Co-authored-by: Yacine Benichou <[email protected]> * Fix typescript issues * Edits * More edits not included in previous commit * Updates * Fix typo in threshold variable name --------- Co-authored-by: Yacine Benichou <[email protected]>
yacine-benichou
force-pushed
the
move-chain-data
branch
from
August 8, 2023 09:03
e438d6c
to
13b5ccf
Compare
simkasss
added a commit
to simkasss/documentation
that referenced
this pull request
Aug 8, 2023
* wip * wip * wip * wip * wip * wip * wip * wip * wip * change to absolute imports * update imports * update supportedNetworkShortcut * Add capability for feed notices (smartcontractkit#1440) * Add feed notice capability --------- Co-authored-by: Yacine Benichou <[email protected]> * Fix typescript issues * Edits * More edits not included in previous commit * Updates * Fix typo in threshold variable name --------- Co-authored-by: Yacine Benichou <[email protected]> * fix import --------- Co-authored-by: Dwight Lyle <[email protected]> Co-authored-by: Yacine Benichou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates issues
relates #1423
Description
The chains data file moved to features/data in order to use the same chains data source across different products.
Changes