Browser simulateScript - restore build #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/FRONT-3851
Hey while debugging Firefox issues with simulate script I digged up the above ticket. During our initial implementation I've built
simulateScript
for frontend usage once and copied the output to our front end repo. While it got us moving now when we have package published I believe we could be using proper way.There are few things happening here:
Is that the intention? I could still see
package.json
script havingbuild:browser
script (which wasn't working anymore).In this PR I'm restoring everything needed to build that simulate package. I noticed repo started using yarn so I adjusted PR for that (no more
package-lock.json
). All dependencies required to build front end shouldn't end up being shipped in the package as they are dev dependencies. If however it's still no longer the business of functions-toolkit package to build front end simulator I might try to extract building process somewhere else.That's because it couldn't handle the dynamic nature of allowed modules. I refactored this part of the code a bit to make sure there are no warnings during the build. This shall affect only browser simulator not deno version.