Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental LOOPP-enabling adjustment to MaxDurationQuery #62

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Experimental LOOPP-enabling adjustment to MaxDurationQuery #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion offchainreporting2/internal/protocol/report_generation_leader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,13 @@ func (repgen *reportGenerationState) startRound() {
repgen.leaderState.readyToStartRound = false
var query types.Query
{
ctx, cancel := context.WithTimeout(repgen.ctx, repgen.config.MaxDurationQuery)
maxDurationQuery := repgen.config.MaxDurationQuery
if maxDurationQuery == 0 {
// Some feeds are configured to zero due to the in-memory implementation of Query being a no-op.
// This is incompatible with GRPC/LOOPPs, which short circuits on the cancelled context, so we override the value.
maxDurationQuery = 500 * time.Millisecond // TODO from config?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100ms is passing the smoke tests.

Suggested change
maxDurationQuery = 500 * time.Millisecond // TODO from config?
maxDurationQuery = 100 * time.Millisecond // TODO from config?

We can likely go even lower.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied this and rebased over here: #68

}
ctx, cancel := context.WithTimeout(repgen.ctx, maxDurationQuery)
defer cancel()

ins := loghelper.NewIfNotStopped(
Expand Down