Introduce a newline only mode #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kybishop
force-pushed
the
do-not-reformat-vertical-space
branch
from
0da67d4 to
418fd7b
Compare
emkguts
requested changes
Feb 12, 2025
kybishop
commented
Feb 13, 2025
| @@ -4,15 +4,16 @@ | |||
|
|
|||
| # Quokka | |||
|
|
|||
| <img src="docs/assets/quokka.png" alt="A happy quokka with style" width="300"/> | |||
There was a problem hiding this comment.
Lots of auto-formatting from prettier in here. I think worth keeping the changes.
emkguts
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserving the original newlines turns out to be very non-trivial... though perhaps there is some secret sauce with walking ASTs that I'm unaware of that enables one to preserve the original formatting.
Until/unless that is discovered, this is a middle ground that lets you do all the newline fixes in one fell swoop before enabling Quokka wholesale.
For anyone wondering or interested in taking a look, here is the line responsible for shrinking down newlines (it took me far too long to figure out it wasn't a standard AST transformation elsewhere in the repo 🤦)