Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inflow Navigation #401

Merged
merged 43 commits into from
Oct 29, 2024
Merged

Inflow Navigation #401

merged 43 commits into from
Oct 29, 2024

Conversation

JNdhlovu
Copy link
Contributor

@JNdhlovu JNdhlovu commented Jul 3, 2024

Story: https://app.shortcut.com/smileid/story/10427/android-allow-in-flow-navigation-in-sdk-screens

Summary

Allow the SDK to handle navigation inflow

Known Issues

n/A

Test Instructions

All products should run as before

  • Smartselfie enroll
  • Smartselfie auth
  • Biometric KYC
  • Document Verification
  • Enhanced Document verification

Screenshot

N/A

@JNdhlovu JNdhlovu requested a review from a team as a code owner July 3, 2024 13:45
@JNdhlovu JNdhlovu marked this pull request as draft July 3, 2024 13:45
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 23, 2024
@JNdhlovu JNdhlovu removed the Stale label Jul 29, 2024
@JNdhlovu JNdhlovu marked this pull request as ready for review July 30, 2024 12:13
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 26, 2024
@github-actions github-actions bot removed the Stale label Aug 27, 2024
@JNdhlovu JNdhlovu changed the title Compose navigation WIP Inflow Navigation Sep 19, 2024
@JNdhlovu JNdhlovu temporarily deployed to Play Store Internal App Sharing October 18, 2024 10:55 — with GitHub Actions Inactive
@JNdhlovu JNdhlovu temporarily deployed to Play Store Internal App Sharing October 18, 2024 12:46 — with GitHub Actions Inactive
@JNdhlovu JNdhlovu had a problem deploying to Play Store Internal App Sharing October 22, 2024 11:52 — with GitHub Actions Error
@JNdhlovu JNdhlovu temporarily deployed to Play Store Internal App Sharing October 22, 2024 12:11 — with GitHub Actions Inactive
@JNdhlovu JNdhlovu merged commit 5ef6944 into main Oct 29, 2024
4 checks passed
@JNdhlovu JNdhlovu deleted the feature/inflownav branch October 29, 2024 11:20
jumaallan added a commit that referenced this pull request Nov 6, 2024
* feat:sdk-navigation

* feat: type safe nav wip

* fix: undo tests renaming

* feat: custom nav types

* feat: working nav

* feat:replace composables for enrollment with graph nav

* feat: main graph and reusable composble for nav

* feat: bump compose nav versions

* feat: refactor with seperation between orchestrated and indvidual screens

* fix: tests

* chore: bump compose navigation version

* feat: docs

* feat: main nav fixes

* feat: nav complete

* feat: nav complete

* feat: nav complete

* fix: unit tests for doc v and enhanced doc v

* feat: callbacks fixes

* feat: compose stack fixes and retries

* feat: pr feedback fixes

* feat: merge main

* feat: fix transition issue delay

* fix: nav cancelled actions

* feat: pop transitions

* feat: pop transitions on orch nav

---------

Co-authored-by: Juma Allan <[email protected]>
jumaallan added a commit that referenced this pull request Nov 7, 2024
* feat:sdk-navigation

* feat: type safe nav wip

* fix: undo tests renaming

* feat: custom nav types

* feat: working nav

* feat:replace composables for enrollment with graph nav

* feat: main graph and reusable composble for nav

* feat: bump compose nav versions

* feat: refactor with seperation between orchestrated and indvidual screens

* fix: tests

* chore: bump compose navigation version

* feat: docs

* feat: main nav fixes

* feat: nav complete

* feat: nav complete

* feat: nav complete

* fix: unit tests for doc v and enhanced doc v

* feat: callbacks fixes

* feat: compose stack fixes and retries

* feat: pr feedback fixes

* feat: merge main

* feat: fix transition issue delay

* fix: nav cancelled actions

* feat: pop transitions

* feat: pop transitions on orch nav

---------

Co-authored-by: Juma Allan <[email protected]>
jumaallan added a commit that referenced this pull request Nov 8, 2024
* reworking camera capture

* Inflow Navigation (#401)

* feat:sdk-navigation

* feat: type safe nav wip

* fix: undo tests renaming

* feat: custom nav types

* feat: working nav

* feat:replace composables for enrollment with graph nav

* feat: main graph and reusable composble for nav

* feat: bump compose nav versions

* feat: refactor with seperation between orchestrated and indvidual screens

* fix: tests

* chore: bump compose navigation version

* feat: docs

* feat: main nav fixes

* feat: nav complete

* feat: nav complete

* feat: nav complete

* fix: unit tests for doc v and enhanced doc v

* feat: callbacks fixes

* feat: compose stack fixes and retries

* feat: pr feedback fixes

* feat: merge main

* feat: fix transition issue delay

* fix: nav cancelled actions

* feat: pop transitions

* feat: pop transitions on orch nav

---------

Co-authored-by: Juma Allan <[email protected]>

* feat: bump version to 10.3.3 (#473)

* feat: bump version to 10.3.3

* feat: changelog format

* feat: bump snapshot version (#474)

* Bump the all group with 3 updates (#472)

* Bump org.jetbrains.kotlinx:kotlinx-serialization-json in the all group (#477)

* Bump the agp group with 2 updates (#475)

* Bump com.google.devtools.ksp in the kotlin group (#471)

* Bump the androidx group with 8 updates (#476)

* feat: skip api submission (#478)

* prep: release 10.3.4 (#479)

* Prep/10.3.5 (#481)

* prep: release 10.3.4

* feat: bump version to 10.3.5

* updated CHANGELOG.md

---------

Co-authored-by: JNdhlovu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jumaallan added a commit that referenced this pull request Dec 13, 2024
* New UI Instructions Screen (#449)

* setting up paparazzi

* setting up v3 instruction screen

* added selfie capture screen ui and tests

* add v2 UI

* bump up VERSION (#455)

* Bump the androidx group with 5 updates (#454)

* Bump the agp group with 2 updates (#453)

* add instruction screen to new ui

* duplicate theme and cleaning up

* updated selfie capture flow

* updated tests

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix Insecure Object Serialization (#456)

* fix unsecure object serialization

* updated CHANGELOG.md

* updated CHANGELOG.md

* bump up version (#457)

* Bump peter-evans/create-pull-request in the github-actions group (#458)

* bump up agp version (#459)

* Bump com.slack.lint.compose:compose-lint-checks in the all group (#461)

* Bump the androidx group with 5 updates (#460)

* Bump the kotlin group with 5 updates (#462)

* Bump the all group with 4 updates (#464)

* feat: scale document bitmaps based on available memory (#465)

* feat: scale document bitmaps based on available memory

* chore: fix docv tests

* feat: refactor on capture get memory first

* chore: undo test crashlytics

* fix: throw oom error when encountered

* chore: update changelog

* Update CHANGELOG.md

Co-authored-by: Ed Fricker <[email protected]>

---------

Co-authored-by: Ed Fricker <[email protected]>

* chore: bump sdk version to 10.3.3 (#467)

* Bump io.github.ujizin:camposer from 0.4.1 to 0.4.2 in the all group (#470)

* Bump the androidx group with 3 updates (#469)

* Bump the agp group with 2 updates (#468)

* Inflow Navigation (#401)

* feat:sdk-navigation

* feat: type safe nav wip

* fix: undo tests renaming

* feat: custom nav types

* feat: working nav

* feat:replace composables for enrollment with graph nav

* feat: main graph and reusable composble for nav

* feat: bump compose nav versions

* feat: refactor with seperation between orchestrated and indvidual screens

* fix: tests

* chore: bump compose navigation version

* feat: docs

* feat: main nav fixes

* feat: nav complete

* feat: nav complete

* feat: nav complete

* fix: unit tests for doc v and enhanced doc v

* feat: callbacks fixes

* feat: compose stack fixes and retries

* feat: pr feedback fixes

* feat: merge main

* feat: fix transition issue delay

* fix: nav cancelled actions

* feat: pop transitions

* feat: pop transitions on orch nav

---------

Co-authored-by: Juma Allan <[email protected]>

* feat: bump version to 10.3.3 (#473)

* feat: bump version to 10.3.3

* feat: changelog format

* feat: bump snapshot version (#474)

* Bump the all group with 3 updates (#472)

* Bump org.jetbrains.kotlinx:kotlinx-serialization-json in the all group (#477)

* Bump the agp group with 2 updates (#475)

* Bump com.google.devtools.ksp in the kotlin group (#471)

* Bump the androidx group with 8 updates (#476)

* feat: skip api submission (#478)

* prep: release 10.3.4 (#479)

* Smart Selfie Capture Flow (#497)

* reworking smart selfie flow

* code formatting and linting

* updated capture flow to show animations

* mark submitJob as non suspend

* reworking directives and lottie animations

* reworking shape indicator v2

* updated lottie animations

* cleaned up animations and capture ui

* updated hints to show different states

* cleaning up progress updates

* cleaning up animations

* updated haptic feedback

* updated the progress to make it more natural

* cleaning up the background and flaky animations

* updated naming

* updated the animations lottie files

* fixed the progress bars not filling up well

* fixed portrait lock on image

* make progress update faster and fixed orientation lottie

* updated the force brightness composable to keep the screen on

* added metadata and updated strings

* revert nav changes

* bump up to 10.4.0

* updated extension class and theming

* updated changelog

* updated ktlint version

* disable linting temporarily

* disable linting temporarily

* cleaning up

* fixed broken tests

* update preview

* fixed device spec

* added cancel button

* fixed inconsistent document type setup

* updated changelog

* renamed enhanced view model

* cleaning up

* update camera metadata

* updated build configs

* updated ktlint setup

* updated ktlint setup

* disable ktlint

* fixed lint issue

* fixed lint issues

* updated changelog

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JNdhlovu <[email protected]>
Co-authored-by: Ed Fricker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants