Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatible kotlin version #549

Closed
wants to merge 2 commits into from

Conversation

JNdhlovu
Copy link
Contributor

Story: https://app.shortcut.com/smileid/story/14970/fix-the-issue-preventing-dialogs-from-closing-in-the-sdk-flow-especially-after-a-failure-as-they-currently-remain-stuck

Summary

Not to be merged only for creating a backwards compatible kotlin version

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@prfectionist
Copy link

prfectionist bot commented Feb 13, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Security patch regression:
Downgrading multiple dependencies, especially security-related ones like Sentry (7.20.1 -> 7.18.1), could reintroduce patched security vulnerabilities. A thorough security impact assessment of these version downgrades is recommended.

⚡ Recommended focus areas for review

Version Compatibility
Downgrading multiple library versions could introduce compatibility issues between interdependent libraries. Special attention needed for compose-bom, kotlin, and coroutines version changes.

Security Downgrade
Downgrading Sentry from 7.20.1 to 7.18.1 may miss important security fixes or improvements in crash reporting capabilities

@prfectionist
Copy link

prfectionist bot commented Feb 13, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Possible issue
Use existing stable version instead of future/non-existent version for dependencies

The androidx-compose-bom version "2024.11.00" appears to be a future/non-existent
version. Use the latest stable version (e.g., 2024.01.00) to avoid potential
compatibility issues.

gradle/libs.versions.toml [6]

-androidx-compose-bom = "2024.11.00"
+androidx-compose-bom = "2024.01.00"
Suggestion importance[1-10]: 9

Why: Using a non-existent future version (2024.11.00) would cause build failures. The suggestion to use an existing stable version is critical for project functionality.

9
Possible bug
Use correct version number format for library dependency

The coroutines version 1.9.0 seems incorrect as the latest version follows 1.x.x
format (e.g., 1.7.x). This might cause compatibility issues.

gradle/libs.versions.toml [21]

-coroutines = "1.9.0"
+coroutines = "1.7.3"
Suggestion importance[1-10]: 9

Why: The coroutines version 1.9.0 is invalid and would cause build failures. Correcting to a valid version format (1.7.3) is essential for project compilation.

9
Best practice
Use stable version instead of beta/preview version for production dependencies

The Kotlin version 2.0.21 is still in beta/preview. Consider using the latest stable
version (1.9.x) for production environments to ensure better stability and
compatibility.

gradle/libs.versions.toml [24-26]

-kotlin = "2.0.21"
-ksp = "2.0.21-1.0.28"
+kotlin = "1.9.22"
+ksp = "1.9.22-1.0.16"
Suggestion importance[1-10]: 8

Why: Using beta versions in production can lead to stability issues. The suggestion to use Kotlin 1.9.22 stable instead of 2.0.21 beta is important for production reliability.

8

@JNdhlovu JNdhlovu closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant