Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prep release 10.4.3 snapshot #550

Closed
wants to merge 3 commits into from

Conversation

JNdhlovu
Copy link
Contributor

@JNdhlovu JNdhlovu commented Feb 13, 2025

Story: https://app.shortcut.com/smileid/story/14970/fix-the-issue-preventing-dialogs-from-closing-in-the-sdk-flow-especially-after-a-failure-as-they-currently-remain-stuck

Summary

Not to be merged only for creating a backwards compatible kotlin version based on 10.4.2 but with kotlin 2.0.x

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@prfectionist
Copy link

prfectionist bot commented Feb 13, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Downgrade
Multiple library versions are being downgraded to older versions which could introduce compatibility issues or regressions. Key examples include Kotlin from 2.1.0 to 2.0.21, Coroutines from 1.10.1 to 1.9.0, and several AndroidX libraries.

@prfectionist
Copy link

prfectionist bot commented Feb 13, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Possible issue
Avoid downgrading dependencies to older versions that may lack important fixes and improvements

Consider using more recent versions of critical dependencies. The PR downgrades
several dependencies to older versions which could miss important bug fixes and
security patches. For example, accompanist-permissions is downgraded from 0.37.0 to
0.36.0, android-gradle-plugin from 8.8.0 to 8.7.3, and androidx-activity from 1.10.0
to 1.9.3.

gradle/libs.versions.toml [2-4]

-accompanist-permissions = "0.36.0"
-android-gradle-plugin = "8.7.3"
-androidx-activity = "1.9.3"
+accompanist-permissions = "0.37.0"
+android-gradle-plugin = "8.8.0"
+androidx-activity = "1.10.0"
Suggestion importance[1-10]: 8

Why: Downgrading multiple critical dependencies to older versions could introduce security vulnerabilities and miss important bug fixes. This affects core build tools and UI components that are essential for app stability and security.

8

lib/VERSION Outdated Show resolved Hide resolved
@JNdhlovu JNdhlovu closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant