fix gz decompress so that we get the complete xml database #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 75.62% 75.64% +0.01%
==========================================
Files 155 155
Lines 28451 28471 +20
==========================================
+ Hits 21517 21537 +20
Misses 6934 6934
|
Alexander-Sol
requested changes
Jun 29, 2023
nbollis
previously approved these changes
Jul 3, 2023
Alexander-Sol
approved these changes
Jul 3, 2023
elaboy
approved these changes
Jul 3, 2023
nbollis
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been intermittent trouble decompressing an xml file that is compressed as .gz. I think the trouble is that we were simultaneously streaming the decompression and the xml to yield protein entries. In this PR, i separate this into two steps. First I completely decompress the file into a temp.xml. Then i stream this temp file into protein entries. Then I delete the temp file.