-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PP Ups to be edited #10167
Open
dot-Comfey
wants to merge
7
commits into
smogon:master
Choose a base branch
from
dot-Comfey:moveppups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow PP Ups to be edited #10167
Commits on Feb 11, 2024
-
Server-side change; will post more on the client-side.
Configuration menu - View commit details
-
Copy full SHA for 0dafd30 - Browse repository at this point
Copy the full SHA 0dafd30View commit details -
Configuration menu - View commit details
-
Copy full SHA for c777c20 - Browse repository at this point
Copy the full SHA c777c20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2b91b - Browse repository at this point
Copy the full SHA 0e2b91bView commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65f8ed6 - Browse repository at this point
Copy the full SHA 65f8ed6View commit details
Commits on Oct 13, 2024
-
Update TEAMS.md and fix unpacking
Regarding uploading to the team database: I did not test it, but by inspecting the code, it doesn't seem like anything needs to be done as the values should be preserved.
Configuration menu - View commit details
-
Copy full SHA for ac69b4b - Browse repository at this point
Copy the full SHA ac69b4bView commit details
Commits on Oct 15, 2024
-
Move PP Up check outside of the validator
Probably better to avoid unusual PP values this way. Also changed the packed format to treat empty values as 3 PP Ups.
Configuration menu - View commit details
-
Copy full SHA for b5a51ce - Browse repository at this point
Copy the full SHA b5a51ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for abc0116 - Browse repository at this point
Copy the full SHA abc0116View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.