-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Convert pval and qval to heatmap #123
Conversation
WalkthroughThe changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
workflow/resources/datavzrd/diffexp-template.yaml (1)
214-235
: LGTM! Consider adding a legend for clarity.The change from bar plots to heatmaps for 'pval' and 'qval' visualization is a good improvement. The new domain [0, 0.05, 0.25] provides better granularity for significant values, and the color range is appropriate for representing significance levels.
Consider adding a legend to explain the color scale, especially since the domain is not evenly distributed (0, 0.05, 0.25). This would help users interpret the heatmap more accurately.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- workflow/resources/datavzrd/diffexp-template.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
workflow/resources/datavzrd/diffexp-template.yaml (1)
Line range hint
1-337
: Summary of changes and recommendations
The changes for the 'transcripts' dataset successfully implement heatmaps for 'pval' and 'qval' visualization, improving the representation of significance levels.
There's a discrepancy between the AI-generated summary and the visible changes regarding the 'genes_aggregated' dataset. This needs to be verified and addressed if necessary.
Consider adding a legend to the heatmaps to improve interpretability, especially given the non-linear domain distribution.
Overall, the implemented changes align well with the PR objectives of enhancing the visualization of p-values and q-values in the differential expression report.
🧰 Tools
🪛 yamllint
[error] 237-237: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. So if you have tested that this all works, feel free to merge. One thing I would double-check, is that values above 0.25 work with this domain definition. But you're the datavzrd expert, here... ;)
Works for sure. I think the default for |
🤖 I have created a release *beep* *boop* --- ## [2.8.2](v2.8.1...v2.8.2) (2024-10-18) ### Bug Fixes * Convert pval and qval to heatmap ([#123](#123)) ([478c759](478c759)) * Move NA values to end of table ([#124](#124)) ([df807a5](df807a5)) * Update max in memory rows for diffexp report ([#122](#122)) ([830e678](830e678)) ### Performance Improvements * Update to latest datavzrd wrapper ([#125](#125)) ([3a4c020](3a4c020)) * Update to latest datavzrd wrapper version ([#120](#120)) ([7b2767c](7b2767c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR converts pval and qval in the transcripts view of the diffexp report from bar plots to heatmaps.
Summary by CodeRabbit
pval
andqval
in bothtranscripts
andgenes_aggregated
datasets.These changes provide a more detailed and visually informative way to interpret data significance.