Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to webhook-ui #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adapt to webhook-ui #42

wants to merge 5 commits into from

Conversation

zzuziak
Copy link

@zzuziak zzuziak commented Oct 31, 2022

Fixes partially webhook-ui/1

Background

This PR adapts snapshot-webhook to handle automated webhook subscriptions implemented in: webhook-ui

Changes proposed in this pull request:

  • add new api endpoints for:
    • fetching all subscirptions of an owner (:warning: needs further update to secure the endpoint and return the subs only to verified owner)
    • creating and updating a subscription record
  • new subscribers module with methods querying DB
  • renaming of functions to make a difference between subscriptions from snapshot.org and webhook subscriptions

Remainings TODOS (cross-repo)

  • handle verification for fetching all subscriptions from snapshot-webhook, mentioned in the comment in the code
  • might be messy, but would be great to rename tables from subscriptions and subscribers to discord_subscribers and webhook_subscribers or something like that 🤔

@zzuziak zzuziak marked this pull request as ready for review October 31, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant