feat: Remove mixpanel (#4862)

* feat: Remove mixpanel * Return without assigning * remove await
snapshot-labs · Sep 2, 2024 · a95cfe3 · a95cfe3
1 parent a052469
commit a95cfe3
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 106 deletions.
diff --git a/.env b/.env
@@ -10,5 +10,4 @@ VITE_DEFAULT_NETWORK=1
 VITE_PUSHER_BEAMS_INSTANCE_ID=2e080021-d495-456d-b2cf-84f9fd718442
 VITE_SHUTTER_EON_PUBKEY=0x0e6493bbb4ee8b19aa9b70367685049ff01dc9382c46aed83f8bc07d2a5ba3e6030bd83b942c1fd3dff5b79bef3b40bf6b666e51e7f0be14ed62daaffad47435265f5c9403b1a801921981f7d8659a9bd91fe92fb1cf9afdb16178a532adfaf51a237103874bb03afafe9cab2118dae1be5f08a0a28bf488c1581e9db4bc23ca
 VITE_ENV=develop
-VITE_MIXPANEL_TOKEN=2ec6cd1b19e790f45cc9a9bb83980c8d
 VITE_ALCHEMY_API_KEY=ombBQyf580z-jx2EVQgJu4eTjePU-a2z
diff --git a/.eslintrc-auto-import.json b/.eslintrc-auto-import.json
@@ -119,7 +119,6 @@
     "useEmailSubscription": true,
     "useEmailFetchClient": true,
     "useStatement": true,
-    "useMixpanel": true,
     "useBalances": true,
     "useAccount": true,
     "usePayment": true,

diff --git a/package.json b/package.json
@@ -58,7 +58,6 @@
     "kubo-rpc-client": "^3.0.2",
     "lodash": "^4.17.21",
     "minisearch": "^6.2.0",
-    "mixpanel-browser": "^2.48.1",
     "remarkable": "^2.0.1",
     "remove-markdown": "^0.5.0",
     "typescript": "^5.2.2",

diff --git a/src/composables/useClient.ts b/src/composables/useClient.ts
@@ -6,7 +6,6 @@ export function useClient() {
   const { notify } = useFlashNotification();
   const { notifyModal } = useModalNotification();
   const { isGnosisSafe } = useGnosis();
-  const { mixpanel } = useMixpanel();
   const { web3 } = useWeb3();
   const auth = getInstance();
   const route = useRoute();
@@ -46,7 +45,7 @@ export function useClient() {
       plugins = payload.metadata.plugins;
 
     if (type === 'create-proposal') {
-      const receipt = await client.proposal(auth.web3, web3.value.account, {
+      return client.proposal(auth.web3, web3.value.account, {
         space: space.id,
         type: payload.type,
         title: payload.name,
@@ -59,36 +58,19 @@ export function useClient() {
         plugins: JSON.stringify(plugins),
         app: DEFINED_APP
       });
-
-      mixpanel.track('Propose', {
-        space: space.id
-      });
-
-      return receipt;
     } else if (type === 'update-proposal') {
-      const receipt = await client.updateProposal(
-        auth.web3,
-        web3.value.account,
-        {
-          proposal: payload.id,
-          space: space.id,
-          type: payload.type,
-          title: payload.name,
-          body: payload.body,
-          discussion: payload.discussion,
-          choices: payload.choices,
-          plugins: JSON.stringify(plugins)
-        }
-      );
-
-      mixpanel.track('Update proposal', {
+      return client.updateProposal(auth.web3, web3.value.account, {
+        proposal: payload.id,
         space: space.id,
-        proposalId: payload.id
+        type: payload.type,
+        title: payload.name,
+        body: payload.body,
+        discussion: payload.discussion,
+        choices: payload.choices,
+        plugins: JSON.stringify(plugins)
       });
-
-      return receipt;
     } else if (type === 'vote') {
-      const receipt = await client.vote(auth.web3, web3.value.account, {
+      return client.vote(auth.web3, web3.value.account, {
         space: space.id,
         proposal: payload.proposal.id,
         type: payload.proposal.type,
@@ -97,74 +79,31 @@ export function useClient() {
         app: DEFINED_APP,
         reason: payload.reason
       });
-
-      mixpanel.track('Vote', {
-        space: space.id,
-        proposalId: payload.proposal.id
-      });
-
-      return receipt;
     } else if (type === 'delete-proposal') {
-      const receipt = await client.cancelProposal(
-        auth.web3,
-        web3.value.account,
-        {
-          space: space.id,
-          proposal: payload.proposal.id
-        }
-      );
-
-      mixpanel.track('Delete proposal', {
+      return client.cancelProposal(auth.web3, web3.value.account, {
         space: space.id,
-        proposalId: payload.proposal.id
+        proposal: payload.proposal.id
       });
-
-      return receipt;
     } else if (type === 'settings') {
-      const receipt = await client.space(auth.web3, web3.value.account, {
+      return client.space(auth.web3, web3.value.account, {
         space: space.id,
         settings: JSON.stringify(payload)
       });
-
-      mixpanel.track('Update space settings', {
-        space: space.id
-      });
-
-      return receipt;
     } else if (type === 'delete-space') {
-      const receipt = await client.deleteSpace(auth.web3, web3.value.account, {
+      return client.deleteSpace(auth.web3, web3.value.account, {
         space: space.id
       });
-
-      mixpanel.track('Delete space', {
-        space: space.id
-      });
-
-      return receipt;
     } else if (type === 'set-statement') {
-      const receipt = await client.statement(auth.web3, web3.value.account, {
+      return client.statement(auth.web3, web3.value.account, {
         space: space.id,
         about: payload.about,
         statement: payload.statement
       });
-
-      mixpanel.track('Set statement', {
-        space: space.id
-      });
-
-      return receipt;
     } else if (type === 'flag-proposal') {
-      const receipt = await client.flagProposal(auth.web3, web3.value.account, {
+      return client.flagProposal(auth.web3, web3.value.account, {
         space: space.id,
         proposal: payload.proposal.id
       });
-
-      mixpanel.track('Flag proposal', {
-        space: space.id,
-        proposalId: payload.proposal.id
-      });
-
-      return receipt;
     }
   }
 

diff --git a/src/composables/useMixpanel.ts b/src/composables/useMixpanel.ts
diff --git a/src/router/index.ts b/src/router/index.ts
@@ -1,5 +1,4 @@
 import { createRouter, createWebHashHistory, RouteLocation } from 'vue-router';
-import { useMixpanel } from '@/composables/useMixpanel';
 
 import DelegateView from '@/views/DelegateView.vue';
 import ExploreView from '@/views/ExploreView.vue';
@@ -29,7 +28,6 @@ import TermsView from '@/views/TermsView.vue';
 // The frontend shows all spaces or just a single one, when being accessed
 // through that space's custom domain.
 const { domain, domainAlias } = useApp();
-const { mixpanel } = useMixpanel();
 
 const routes: any[] = [];
 
@@ -189,13 +187,6 @@ const router = createRouter({
   }
 });
 
-router.afterEach(to => {
-  mixpanel.track_pageview({
-    page_name: to.name,
-    page_path: to.path
-  });
-});
-
 export { routes };
 
 export default router;
diff --git a/yarn.lock b/yarn.lock
@@ -6757,11 +6757,6 @@ minisearch@^6.2.0:
   resolved "https://registry.yarnpkg.com/minisearch/-/minisearch-6.2.0.tgz#310b50508551f22e10815f5baedeeeded03a6b5d"
   integrity sha512-BECkorDF1TY2rGKt9XHdSeP9TP29yUbrAaCh/C03wpyf1vx3uYcP/+8XlMcpTkgoU0rBVnHMAOaP83Rc9Tm+TQ==
 
-mixpanel-browser@^2.48.1:
-  version "2.48.1"
-  resolved "https://registry.yarnpkg.com/mixpanel-browser/-/mixpanel-browser-2.48.1.tgz#0fec03d87f57fe2e72c6a4b1df5924436840ece7"
-  integrity sha512-vXTuUzZMg+ht7sRqyjtc3dUDy/81Z/H6FLFgFkUZJqKFaAqcx1JSXmOdY/2kmsxCkUdy5JN5zW9m9TMCk+rxGQ==
-
 mlly@^1.1.1, mlly@^1.2.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/mlly/-/mlly-1.2.0.tgz#f0f6c2fc8d2d12ea6907cd869066689b5031b613"