Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken space delegationPortal settings #4913

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Oct 9, 2024

Summary

Closes: #4912

This PR fixes the broken delegation portal, due to TuneForm not supporting having other thing than a choice list in anyOf, and missing delegationNetwork selector, not supported by TuneForm

How to test

  1. Go to your space settings > Delegation
  2. The form should show properly, with a network selector
  3. It should save without error

@wa0x6e wa0x6e changed the title Fix-support-any-of-format-definition-in-tuneform fix: fix broken space delegationPortal settings Oct 9, 2024
@wa0x6e wa0x6e marked this pull request as ready for review October 9, 2024 19:18
@wa0x6e wa0x6e requested a review from ChaituVR October 9, 2024 19:19
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 7fa7f84 into master Oct 10, 2024
3 of 5 checks passed
@wa0x6e wa0x6e deleted the fix-support-any-of-format-definition-in-tuneform branch October 10, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: delegation portal settings broken
2 participants