chore: replaced old deployer scripts with new one #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Orland0x
commented
Oct 11, 2023
•
Orland0x
commented
- Removes the legacy forge scripts that were on the main branch with the script used to deploy v1.0.0 - v1.2.0.
- Adds a test to run the deployment script locally.
- Add deployment instructions to readme.
Orland0x
force-pushed
the
chore_deployer_script
branch
from
4dd5e84 to
e5043f1
Compare
pscott
previously approved these changes
Oct 16, 2023
README.md
Outdated
| @@ -18,7 +18,8 @@ src | |||
| ├─ voting-strategies | |||
| │ ├─ CompVotingStrategy.sol - "Strategy that uses delegated balances of Comp tokens as voting power" | |||
| │ ├─ OZVotesVotingStrategy.sol - "Strategy that uses delegated balances of OZ Votes tokens as voting power" | |||
| │ ├─ WhitelistVotingStrategy.sol — "Strategy that gives predetermined voting power for members in a whitelist, otherwise zero" | |||
| │ ├─ WhitelistVotingStrategy.sol — "Strategy that gives predetermined voting power for members in a whitelist, otherwise zero. Whitelist is stored in a bytes array On-Chain." | |||
| │ ├─ MerkleWhitelistVotingStrategy.sol — "Strategy that gives predetermined voting power for members in a whitelist, otherwise zero. Whitelist is stored in a Merkle tree Off-Chain, with only the root being stored On-Chain." | |||
There was a problem hiding this comment.
I don't think we should write otherwise zero, as the contract will revert in that case
|
|
||
| if (Space(space).owner() != address(0x1)) { | ||
| // Initialization of the master space was frontrun | ||
| revert SpaceInitializationFailed(); |
There was a problem hiding this comment.
is the owner variable the only variable worth checking ?
There was a problem hiding this comment.
yeah added a check for proposal validation strategy which prevents proposals from being created. That should prevent all actions in the space then i think
script/Deployer.s.sol
Outdated
Comment on lines
224
to
226
| Strategy[] memory emptyStrategyArray = new Strategy[](1); | ||
| emptyStrategyArray[0] = Strategy(address(0x1), new bytes(0)); | ||
| string[] memory emptyStringArray = new string[](1); |
There was a problem hiding this comment.
Might be worth renaming empty to maybe default or unusable or test or Dummy ? (I got confused why this code would not trigger if we were passing empty arrays :p)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.