feat: support 1271 #254
feat: support 1271 #254
Conversation
|
@bonustrack ready for review |
| @@ -26,7 +26,7 @@ contract ProxyFactory is IProxyFactory { | |||
| return | |||
| address( | |||
| uint160( | |||
| uint( | |||
| uint256( | |||
There was a problem hiding this comment.
Any reason for this change? How is it related to 1271 and wouldn't this break compatibility with current deployment?
There was a problem hiding this comment.
uint aliases to uint256, but a lot of people say explicitly using uint256 allows for less ambiguous code :)
There was a problem hiding this comment.
But why do we need this in this PR? Seems completely unrelated, I'd rather have this within another PR.
There was a problem hiding this comment.
Because the linter yells at us. And since we have husky, we can't commit if the linter isn't happy :D
There was a problem hiding this comment.
see initial comment : #254 (comment)
There was a problem hiding this comment.
I see, and these uint256 changes were done by the lint script?
There was a problem hiding this comment.
Some were, but the uint was done manually I reckon
There was a problem hiding this comment.
Everything that is purely formatting is done automatically ; but those that change the code need to be manually done
Closes https://github.com/snapshot-labs/workflow/issues/329
note: had to run
yarn prettierbecause of the husky checks enforced upon committing...