Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network switcher for argent X #546

Closed
wa0x6e opened this issue Jul 27, 2024 · 3 comments · Fixed by #716
Closed

feat: add network switcher for argent X #546

wa0x6e opened this issue Jul 27, 2024 · 3 comments · Fixed by #716
Assignees

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Jul 27, 2024

Like we already do for EVM, we should trigger a wallet network switch on Starknet when the action is not on the correct chain.

This will avoid invalid signature with Argent X, when signing message on a different chainId than the wallet (braavos can sign message on any networks).

The wallet is supporting the networks switch call, see https://github.com/argentlabs/argent-x/blob/0607c5e58742dd33b3737e898ca78e97d7c4fb44/packages/dapp/src/services/wallet.service.ts#L250-L260

Feature should be implemented once:

@Sekhmet
Copy link
Member

Sekhmet commented Jul 29, 2024

We wanted to implement it before, but it didn't work back then (the call was ignored), we should verify if it's functional.

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jul 29, 2024

Will check

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Sep 5, 2024

Regarding different actions support for starknet wallets: starknet-io/get-starknet#212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants