Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network switcher for starknet wallet #716

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Sep 5, 2024

Summary

Closes: #546

This PR adds a network switcher (sn_main <-> sn_sepolia) to argent X wallet (braavos don't support this feature)

How to test

  1. Trigger some action requiring starknet signature
  2. If your wallet is on the expected network, argent X should show the signature popup (existing behavior)
  3. If the wallet is not on the expected network, argent X should show the network switcher popup
  4. If REJECTING the switch, it should cancel the signature
  5. if APPROVING the switch, it should switch to the correct network, and show the signature popup

Note

  • For those using Braavos wallet, the network switcher will be skipped since unsupported, and will directly show the signature popup using the wallet current network (existing behavior)
  • If the target network does not exist, argent X will skip the network switcher popup, and just show the signature popup with the wallet existing network (existing behavior)

@wa0x6e wa0x6e requested a review from Sekhmet September 5, 2024 13:02
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@wa0x6e wa0x6e requested a review from Sekhmet September 7, 2024 03:53
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Sekhmet Sekhmet merged commit 9021c5c into master Sep 9, 2024
3 checks passed
@Sekhmet Sekhmet deleted the feat-546-add-network-switcher-for-argent-x branch September 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add network switcher for argent X
3 participants