feat: add settings menu to topnav #1032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
reviewed
Dec 11, 2024
ChaituVR
reviewed
Dec 11, 2024
Sekhmet
reviewed
Dec 18, 2024
Sekhmet
reviewed
Dec 18, 2024
Sekhmet
reviewed
Dec 18, 2024
Sekhmet
reviewed
Dec 19, 2024
There was a problem hiding this comment.
It looks good to me, although I'd like @bonustrack to decide on the UX/UI aspect of this (menu entries, unless it was discussed elsewhere as issue doesn't have any context).
Comment on lines
+223
to
+231
| <UiDropdownItem v-slot="{ active }"> | ||
| <a | ||
| :class="['flex gap-2 items-center', { 'opacity-80': active }]" | ||
| href="https://snapshot.box" | ||
| > | ||
| <IH-bolt :width="16" /> | ||
| Mainnet | ||
| </a> | ||
| </UiDropdownItem> |
There was a problem hiding this comment.
I think it would be weird showing this on snapshot.box and testnet link on testnet.snapshot.box.
|
Let's wait before merging this PR, I'm not sure about the menu links, many of these links or not relevant for most users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/319
This PR adds a new "settings" menu in the top nav, which will contains:
How to test