Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match quorum formula based on contracts #1065

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Dec 19, 2024

Summary

Onchain spaces only take for and abstain votes into quorum progress. Against votes are not counted.

Offchain spaces take all votes into account (for oSnap/SafeSnap).

How to test

  1. Go to onchain space with against votes: http://localhost:8080/#/sep:0x3CB9321Ed733dc336A59199b05b2FC29beA8b66B/proposal/2
  2. Against is not counted towards quorum, proposal is rejected, you can't execute proposal.
  3. Go to onchain space that passed: http://localhost:8080/#/sep:0x3CB9321Ed733dc336A59199b05b2FC29beA8b66B/proposal/4
  4. Quorum counts all votes, proposal is passed, you can execute proposal (at least button shows up, I haven't configured execution on Safe).

Screenshots

image

Onchain spaces only take for and abstain votes into quorum progress.
Against votes are not counted.

Offchain spaces take all votes into account (for oSnap/SafeSnap).
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit e89c157 into master Dec 19, 2024
2 checks passed
@Sekhmet Sekhmet deleted the sekhmet/current-quorum branch December 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants