fix leak by releasing ref to observed element

snewcomer · Nov 10, 2022 · f1b3f14 · f1b3f14
1 parent fe89c8c
commit f1b3f14
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -9,7 +9,7 @@ export interface IOptions {
 }
 
 type StateForRoot = {
-  elements: [HTMLElement];
+  elements: HTMLElement[];
   options: IOptions;
   intersectionObserver: any;
 };
@@ -61,6 +61,11 @@ export default class IntersectionObserverAdmin extends Notifications {
     if (matchingRootEntry) {
       const { intersectionObserver } = matchingRootEntry;
       intersectionObserver.unobserve(target);
+
+      const elIndex = matchingRootEntry.elements.indexOf(target);
+      if (elIndex !== -1) {
+        matchingRootEntry.elements.splice(elIndex, 1);
+      }
     }
   }