Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to become more inline with standard go practice #17

Closed
plastikfan opened this issue Jul 30, 2022 · 1 comment
Closed

refactor to become more inline with standard go practice #17

plastikfan opened this issue Jul 30, 2022 · 1 comment
Assignees
@plastikfan
Labels
refactor Refactor code

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Jul 30, 2022 •
edited
Loading

See: same issue on arcadia-lib

i18n should be able to be shared by multiple apps in the repo, therefore it should not be located under the app directory, should be at same level. i18n will only be dependent on internal l10n and command can be dependent on i18n, now that the circular dependency has been fixed (by moving i18n out of main, which is the wrong place).

main must contain as little code as possible and can never contain anything that other code depends on.
@plastikfan plastikfan added the refactor Refactor code label Jul 30, 2022
@plastikfan plastikfan self-assigned this Jul 30, 2022
This was referenced Aug 1, 2022
Closed
Closed
plastikfan added a commit that referenced this issue Aug 1, 2022
@plastikfan
ref: replace global state with bootstrap (#17)
d7800e0 
ref: move i18n into new internal package translate (#17)

ref: define a parameter set for root command (#17)

ref: replace init with bootstrap (#17)

ref: remove global state from widget command (#17)
@plastikfan
Copy link
Contributor Author

This actually implemented the bootstrap mechanism to get rid of global state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plastikfan