Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEF file for Container, and CMake build code #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcookman
Copy link

This PR does two main things:

  1. Create a file oxsx_container.def, which can be used to create a Container which holds all of the external dependencies necessary to run OXSX.
  2. Add a bunch of CMake files, so that one can compile OXSX within the container.

Some instructions about how to run this has been added to the README.
I also removed a couple of redundant includes in some files, as a cleanup.

@willp240
Copy link

This looks cool Daniel! I'm getting an error when trying to build though, probably a my end problem. I think it's because the GLIBC version in the RAT image is not compatible with the one on EL 9. I'll try and play a bit more next week but it might be best if I try and rebuild the RAT container on EL 9 (I said I was going to do that a while back).

In the meantime, I appreciate the tidied headers! And my only minor comment is we could make "Compiling Your Own Scripts" an h2 header in the README so it doesn't look like a subsection of "Alternative Installation Instructions Using Singularity/Apptainer & CMake"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants