Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-715504: MFA token cache support #988

Merged
merged 55 commits into from
Jan 14, 2025

Add .net7 support

a3cf87a
Select commit
Loading
Failed to load commit list.
Merged

SNOW-715504: MFA token cache support #988

Add .net7 support
a3cf87a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 14, 2025 in 0s

86.19% (-0.14%) compared to 27b0ae4

View this Pull Request on Codecov

86.19% (-0.14%) compared to 27b0ae4

Details

Codecov Report

Attention: Patch coverage is 84.93894% with 111 lines in your changes missing coverage. Please review.

Project coverage is 86.19%. Comparing base (27b0ae4) to head (a3cf87a).

Files with missing lines Patch % Lines
...ager/Infrastructure/SFCredentialManagerFileImpl.cs 80.80% 34 Missing and 9 partials ⚠️
...astructure/SFCredentialManagerWindowsNativeImpl.cs 81.17% 14 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/SessionPool.cs 82.00% 3 Missing and 6 partials ⚠️
...e.Data/Client/SnowflakeCredentialManagerFactory.cs 84.61% 4 Missing and 4 partials ⚠️
Snowflake.Data/Core/Session/SFSession.cs 78.94% 6 Missing and 2 partials ⚠️
Snowflake.Data/Core/Tools/DirectoryOperations.cs 58.82% 7 Missing ⚠️
Snowflake.Data/Core/Tools/UnixOperations.cs 83.33% 4 Missing and 1 partial ⚠️
...e.Data/Core/Authenticator/MFACacheAuthenticator.cs 78.94% 3 Missing and 1 partial ⚠️
Snowflake.Data/Core/Tools/FileOperations.cs 55.55% 3 Missing and 1 partial ⚠️
Snowflake.Data/Core/Tools/StringUtils.cs 75.00% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   86.33%   86.19%   -0.14%     
==========================================
  Files         121      131      +10     
  Lines       11849    12549     +700     
  Branches     1213     1286      +73     
==========================================
+ Hits        10230    10817     +587     
- Misses       1331     1413      +82     
- Partials      288      319      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov