Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional parameter TELEMETRY_SERVICE_AVAILABLE to support disabling Telemetry #2034

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

semyonmelman
Copy link

@semyonmelman semyonmelman commented Jan 16, 2025

Added additional parameter TELEMETRY_SERVICE_AVAILABLE to support disabling Telemetry

Overview

SNOW-1881874

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: SNOW-1881874: CLIENT_TELEMETRY_ENABLED is always true and there is no possibility to override it #2029

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    So basically additional variable TELEMETRY_SERVICE_AVAILABLE was added to have control over isTelemetryServiceAvailable variable in TelemetryClient that was hardcoded.

@semyonmelman semyonmelman requested a review from a team as a code owner January 16, 2025 14:30
Copy link

github-actions bot commented Jan 16, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@semyonmelman
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@semyonmelman semyonmelman marked this pull request as ready for review January 17, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant