Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1886186 - gather threadExecutor callables and call Future.get() to prevent silent fails #2035

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SNOW-1886186 - gather threadExecutor callables and call Future.get() to prevent silent fails #2035

wants to merge 5 commits into from
+172 −123

Conversation

sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik commented Jan 16, 2025 •
edited by jira bot
Loading

Overview

SNOW-1886186

Currently errors thrown inside download/upload File callables are ignored since future.get() is not executed. This PR adds aggregating futures and then calling get to surface any inner exception that occurred during download/upload

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-mkubik sfc-gh-mkubik requested a review from a team as a code owner January 16, 2025 17:35
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jan 23, 2025
View reviewed changes
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
@@ -1792,6 +1793,7 @@ private void downloadFiles() throws SnowflakeSQLException {
throw new SnowflakeSQLLoggedException(
queryID, session, ErrorCode.INTERRUPTED.getMessageCode(), SqlState.QUERY_CANCELED);
} catch (ExecutionException ex) {
logger.error("Exception encountered within threadExecutor flow in downloadFiles");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add ex to the log

src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
@@ -1664,6 +1664,7 @@ private void uploadStream() throws SnowflakeSQLException {
throw new SnowflakeSQLLoggedException(
queryID, session, ErrorCode.INTERRUPTED.getMessageCode(), SqlState.QUERY_CANCELED);
} catch (ExecutionException ex) {
logger.error("Exception encountered within threadExecutor flow in uploadStream");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add ex to the log

src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
@@ -1902,6 +1904,7 @@ private void uploadFiles(Set<String> fileList, int parallel) throws SnowflakeSQL
throw new SnowflakeSQLLoggedException(
queryID, session, ErrorCode.INTERRUPTED.getMessageCode(), SqlState.QUERY_CANCELED);
} catch (ExecutionException ex) {
logger.error("Exception encountered within threadExecutor flow in uploadFiles");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add ex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mkubik @sfc-gh-dprzybysz