fix ThreadPool::with_name warning #10
Conversation
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
|
@snowplowcla I signed it! The Individual Contributor License Agreement v1.0 |
|
Confirmed! @robbinhan has signed the Individual Contributor License Agreement. Thanks so much |
| serde = "1.0.71" | ||
| serde_derive = "1.0.71" | ||
| serde_json = "1.0.26" | ||
| consul = {git = "https://github.com/stusmall/consul-rust.git"} |
There was a problem hiding this comment.
can't we depend on a specific version?
There was a problem hiding this comment.
Yes.
chrononeed new version and some packages need to update togetherconsulclient is not support new consul server- Keep updating
There was a problem hiding this comment.
Sorry, factotum binary is my mistake, I will delete it.
| @@ -83,6 +84,7 @@ pub fn start(args: Args) -> Result<(), String> { | |||
| status: get "/status" => responder::status, | |||
| settings: post "/settings" => responder::settings, | |||
| submit: post "/submit" => responder::submit, | |||
| submit_new: post "/submit/new" => responder::submit, | |||
There was a problem hiding this comment.
Sometimes the same task wants to execute multiple times, and you need to know the results of the run.
use of deprecated item 'threadpool::ThreadPool::new_with_name': use ThreadPool::with_namewhencargo build