-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ThreadPool::with_name warning #10
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
@snowplowcla I signed it! The Individual Contributor License Agreement v1.0 |
Confirmed! @robbinhan has signed the Individual Contributor License Agreement. Thanks so much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I just had a cursory look, I'll let others review properly.
Also I don't think we need the factotum binary in the repo
serde = "1.0.71" | ||
serde_derive = "1.0.71" | ||
serde_json = "1.0.26" | ||
consul = {git = "https://github.com/stusmall/consul-rust.git"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we depend on a specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
chrono
need new version and some packages need to update togetherconsul
client is not support new consul server- Keep updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, factotum binary is my mistake, I will delete it.
@@ -83,6 +84,7 @@ pub fn start(args: Args) -> Result<(), String> { | |||
status: get "/status" => responder::status, | |||
settings: post "/settings" => responder::settings, | |||
submit: post "/submit" => responder::submit, | |||
submit_new: post "/submit/new" => responder::submit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a new
route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes the same task wants to execute multiple times, and you need to know the results of the run.
use of deprecated item 'threadpool::ThreadPool::new_with_name': use ThreadPool::with_name
whencargo build