-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts updates to add global labels #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. If you haven't, I'd run these all through a helm template
to ensure everything is rendering nicely both with and without the presence of labels
.
Good call @jparavisini . I've made some updates to account for trailing whitespace Have run them through helm template with and without passing labels Example with priority-class
and with setting labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the following charts to add global labels to the resources deployed within the chart