Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts updates to add global labels #187

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Charts updates to add global labels #187

merged 13 commits into from
Aug 16, 2024

Conversation

ianarsenault
Copy link
Contributor

@ianarsenault ianarsenault commented Jul 31, 2024

This PR updates the following charts to add global labels to the resources deployed within the chart

  • charts/snowplow-iglu-server
  • charts/priority-class
  • charts/daemonset
  • charts/cron-job
  • charts/cluster-warmer

@ianarsenault ianarsenault self-assigned this Jul 31, 2024
@ianarsenault ianarsenault changed the title charts/priority-class add global labels (closes #180) Charts updates to add global labels Jul 31, 2024
@ianarsenault ianarsenault marked this pull request as ready for review July 31, 2024 17:29
jparavisini
jparavisini previously approved these changes Aug 12, 2024
Copy link
Contributor

@jparavisini jparavisini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. If you haven't, I'd run these all through a helm template to ensure everything is rendering nicely both with and without the presence of labels.

@ianarsenault
Copy link
Contributor Author

Good call @jparavisini . I've made some updates to account for trailing whitespace Have run them through helm template with and without passing labels

Example with priority-class

➜ helm template priority-class priority-class
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: critical
  labels:
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: Critical priority pods that preempt all other priority classes.
globalDefault: false
preemptionPolicy: PreemptLowerPriority
value: 1e+06
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: high
  labels:
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: High priority pods that preempt medium and low tier priority classes.
globalDefault: false
preemptionPolicy: PreemptLowerPriority
value: 900000
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: medium
  labels:
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: Medium priority pods that preempt low tier priority classes. The default for services.
globalDefault: true
preemptionPolicy: PreemptLowerPriority
value: 500000
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: low
  labels:
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: Low priority pods.
globalDefault: false
preemptionPolicy: Never
value: 100000

and with setting labels

➜ helm template priority-class priority-class --set labels.app=my-app --set labels.environment=production
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: critical
  labels:
    app: my-app
    environment: production
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: Critical priority pods that preempt all other priority classes.
globalDefault: false
preemptionPolicy: PreemptLowerPriority
value: 1e+06
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: high
  labels:
    app: my-app
    environment: production
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: High priority pods that preempt medium and low tier priority classes.
globalDefault: false
preemptionPolicy: PreemptLowerPriority
value: 900000
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: medium
  labels:
    app: my-app
    environment: production
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: Medium priority pods that preempt low tier priority classes. The default for services.
globalDefault: true
preemptionPolicy: PreemptLowerPriority
value: 500000
---
# Source: priority-class/templates/priority-class.yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: low
  labels:
    app: my-app
    environment: production
    helm.sh/chart: priority-class-0.2.0
    app.kubernetes.io/name: priority-class
    app.kubernetes.io/instance: priority-class
    app.kubernetes.io/managed-by: Helm
description: Low priority pods.
globalDefault: false
preemptionPolicy: Never
value: 100000

Copy link
Contributor

@Andy-Hay Andy-Hay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianarsenault ianarsenault merged commit df9acdd into main Aug 16, 2024
1 check passed
@ianarsenault ianarsenault deleted the chart-label-updates branch August 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants