Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts/aws-otel-collector add cluster label to scrape config (closes #192) #197

Merged
merged 2 commits into from
Aug 29, 2024
Merged

charts/aws-otel-collector add cluster label to scrape config (closes #192) #197

merged 2 commits into from
Aug 29, 2024

Conversation

ianarsenault
Copy link
Contributor

@ianarsenault ianarsenault commented Aug 29, 2024 •
edited
Loading

This PR updates aws-otel-collector helm chart to provide clusterName in values.yaml to set log group naming, and also add as a label to prometheus receiver scrape config. This allows metric_declarations to also set cluster_name to be able to differentiate kube state metrics by cluster name, along with namespace and deployment

@ianarsenault ianarsenault self-assigned this Aug 29, 2024
@ianarsenault ianarsenault marked this pull request as ready for review August 29, 2024 19:38
@ianarsenault ianarsenault merged commit afb8731 into main Aug 29, 2024
1 check passed
@ianarsenault ianarsenault deleted the charts/aws-otel-collector-labelling branch August 29, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparavisini jparavisini jparavisini approved these changes

Assignees

@ianarsenault ianarsenault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianarsenault @jparavisini