Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace orchestration APIs by test API for native code.test im… #5685

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

PeterSchafer
Copy link
Collaborator

@PeterSchafer PeterSchafer commented Jan 23, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

The main change is an implementation detail for the experimental native snyk code test, which will be using different APIs in the background.
The effect is, that some of the integration tests using mock server don't work anymore and turned out to be duplicates of existing User Journey tests. The duplicates have been removed now. In addition some tests that were limited to the Typescript implementation now also run against the golang native implementation.

The Risk of the change is low, as this feature is still behind a feature flag.

Where should the reviewer start?

How should this be manually tested?

With an org that has consistent ignores enabled, run snyk code test -d and observe that the debug logs to contain network request to the tests endpoint.

...
2025-01-23T20:42:34Z main - > request [0x14000556640]: POST https://api.snyk.io/hidden/orgs/d29ef58f-6684-481d-aca4-b24b58821b85/tests?version=2024-12-21
...

@PeterSchafer PeterSchafer requested a review from a team as a code owner January 23, 2025 18:31
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code.spec.ts
⚠️

"chore: replace orchestration APIs by test API for native code.test implementation" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against c2f5e33

@PeterSchafer PeterSchafer force-pushed the feat/CLI-609_test_api_2 branch from 766bb99 to c2f5e33 Compare January 23, 2025 21:50
@PeterSchafer PeterSchafer merged commit f07f78c into main Jan 24, 2025
7 checks passed
@PeterSchafer PeterSchafer deleted the feat/CLI-609_test_api_2 branch January 24, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants