meta: architecture improvements [WIP] #833
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too much in-place genAttrs of systems. Moving to a single source.
move getDirectories function definition into the library.
Move the massflash source to its own derivation and switch to using writeShellApplication as the derivation builder.
Exchanges the use of copyPathsToStore with filesets. Fix the build inputs so the python environment is not propagated to any downstream consumers of the package which will reduce closure sizes. Split the `buildCommand` into a `buildPhase` and `installPhase`.
Move openwrt_dashboard.json to it's own source derivation.
djacu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Continuing the insanity of #800. Re-organizing the nix infrastructure and simplifying derivations to use standard practices.
Previous Behavior
n/a
New Behavior
Hopefully the same as the old behavior. 🤞
Tests
nix flake checkNeeds verification from the team that things work as expected.